Re: [PATCH] x86/x86-64 PCI domain support

2007-09-02 Thread Randy Dunlap
Jeff Garzik wrote: Randy Dunlap wrote: On Sat, 01 Sep 2007 18:40:27 -0400 Jeff Garzik wrote: Andi Kleen wrote: The second function is redundant? No, it's a hook we must implement, when CONFIG_PCI_DOMAINS is enabled. Then the other function is redundant. No, both functions are required by t

Re: [PATCH] x86/x86-64 PCI domain support

2007-09-02 Thread Jeff Garzik
Randy Dunlap wrote: On Sat, 01 Sep 2007 18:40:27 -0400 Jeff Garzik wrote: Andi Kleen wrote: The second function is redundant? No, it's a hook we must implement, when CONFIG_PCI_DOMAINS is enabled. Then the other function is redundant. No, both functions are required by the interface. by w

Re: [PATCH] x86/x86-64 PCI domain support

2007-09-02 Thread Randy Dunlap
On Sat, 01 Sep 2007 18:40:27 -0400 Jeff Garzik wrote: > Andi Kleen wrote: > >>> The second function is redundant? > >> No, it's a hook we must implement, when CONFIG_PCI_DOMAINS is enabled. > > > > Then the other function is redundant. > > No, both functions are required by the interface. by w

Re: [PATCH] x86/x86-64 PCI domain support

2007-09-02 Thread Muli Ben-Yehuda
On Sat, Sep 01, 2007 at 10:32:23AM -0400, Jeff Garzik wrote: > > Now that the dust has settled and the prep work is upstream, adding > PCI edomain support to x86 is a lot more straightforward. > > Targetted for 2.6.24. Looks good to me. Cheers, Muli - To unsubscribe from this list: send the lin

Re: [PATCH] x86/x86-64 PCI domain support

2007-09-01 Thread Jeff Garzik
Andi Kleen wrote: The second function is redundant? No, it's a hook we must implement, when CONFIG_PCI_DOMAINS is enabled. Then the other function is redundant. No, both functions are required by the interface. Jeff - To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH] x86/x86-64 PCI domain support

2007-09-01 Thread Andi Kleen
> > The second function is redundant? > > No, it's a hook we must implement, when CONFIG_PCI_DOMAINS is enabled. Then the other function is redundant. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo in

Re: [PATCH] x86/x86-64 PCI domain support

2007-09-01 Thread Jeff Garzik
Andi Kleen wrote: +config PCI_DOMAINS + bool "PCI domain support" + depends on PCI I don't think this should be a config option. CONFIG_PCI_DOMAINS is referenced in arch-neutral code, so the symbol _must_ be defined. It can be hidden, perhaps, if that makes our x86 maintainer

Re: [PATCH] x86/x86-64 PCI domain support

2007-09-01 Thread Andi Kleen
> > +config PCI_DOMAINS > + bool "PCI domain support" > + depends on PCI I don't think this should be a config option. But there should be a pci=... option with Documentation to turn it off at runtime > +static inline int pci_proc_domain(struct pci_bus *bus) > +{ > + return pci_