Re: [PATCH] x86/mm/pti: remove dead logic during user pagetable population

2018-01-07 Thread Jike Song
On Sun, Jan 7, 2018 at 5:48 PM, Thomas Gleixner wrote: > On Sun, 7 Jan 2018, Jike Song wrote: >> On Sun, Jan 7, 2018 at 3:33 AM, Thomas Gleixner wrote: >> > On Sun, 7 Jan 2018, Jike Song wrote: >> > >> > Care to explain why you think this is not needed? >> > >> >> Hi Thomas, >> >> Look at one of

Re: [PATCH] x86/mm/pti: remove dead logic during user pagetable population

2018-01-07 Thread Thomas Gleixner
On Sun, 7 Jan 2018, Jike Song wrote: > On Sun, Jan 7, 2018 at 3:33 AM, Thomas Gleixner wrote: > > On Sun, 7 Jan 2018, Jike Song wrote: > > > > Care to explain why you think this is not needed? > > > > Hi Thomas, > > Look at one of the original code snippets: > > 162 if (pgd_none(*pg

Re: [PATCH] x86/mm/pti: remove dead logic during user pagetable population

2018-01-06 Thread Jike Song
On Sun, Jan 7, 2018 at 4:03 AM, Willy Tarreau wrote: > On Sun, Jan 07, 2018 at 01:50:59AM +0800, Jike Song wrote: >> Signed-off-by: Jike Song > > It would be nice to have a commit message, particularly in this quite > sensitive series... Yes that's useful, will add it in v2 :) > > Willy --

Re: [PATCH] x86/mm/pti: remove dead logic during user pagetable population

2018-01-06 Thread Jike Song
On Sun, Jan 7, 2018 at 3:33 AM, Thomas Gleixner wrote: > On Sun, 7 Jan 2018, Jike Song wrote: > > Care to explain why you think this is not needed? > Hi Thomas, Look at one of the original code snippets: 162 if (pgd_none(*pgd)) { 163 unsigned long new_p4d_page =

Re: [PATCH] x86/mm/pti: remove dead logic during user pagetable population

2018-01-06 Thread Willy Tarreau
On Sun, Jan 07, 2018 at 01:50:59AM +0800, Jike Song wrote: > Signed-off-by: Jike Song It would be nice to have a commit message, particularly in this quite sensitive series... Willy

Re: [PATCH] x86/mm/pti: remove dead logic during user pagetable population

2018-01-06 Thread Thomas Gleixner
On Sun, 7 Jan 2018, Jike Song wrote: Care to explain why you think this is not needed? Thanks, tglx