Re: [PATCH] x86/mce: Clear a useless global variable in mce.c

2014-05-20 Thread Tony Luck
On Tue, May 20, 2014 at 3:02 AM, Borislav Petkov wrote: >> I'm OK with it going - but as I said before I'd like to see mce_callin >> printed (so I can tell if just one cpu showed up, just the cpus from >> one socket, or some other significant number). > > I don't think you want to do this uncondit

Re: [PATCH] x86/mce: Clear a useless global variable in mce.c

2014-05-20 Thread Borislav Petkov
On Mon, May 19, 2014 at 10:06:38PM +, Luck, Tony wrote: > I doubt there is any hope for recovery if not all processors show up > ... things have to be already very broken for the machine check to be > blocked. Good, so this whole babble about the potential of a timeout and whatever is all besi

RE: [PATCH] x86/mce: Clear a useless global variable in mce.c

2014-05-19 Thread Luck, Tony
> I mean, does the machine even recover after some of the cores have gone > into the weeds in #MC? Provided, of course, we don't have a no-way-out > MCE and we can resume execution. I doubt there is any hope for recovery if not all processors show up ... things have to be already very broken for t

Re: [PATCH] x86/mce: Clear a useless global variable in mce.c

2014-05-19 Thread Borislav Petkov
On Mon, May 19, 2014 at 05:59:23PM +, Luck, Tony wrote: > - atomic_inc(&mce_entry); > - > > I have used this in the past (in conjunction with an external debugger) to > diagnose problems (not all cpus showing up in the machine check handler). > > But I suppose these can also be diagnosed

RE: [PATCH] x86/mce: Clear a useless global variable in mce.c

2014-05-19 Thread Luck, Tony
- atomic_inc(&mce_entry); - I have used this in the past (in conjunction with an external debugger) to diagnose problems (not all cpus showing up in the machine check handler). But I suppose these can also be diagnosed from the "Timeout synchronizing ..." message from mce_timed_out() [thoug

Re: [PATCH] x86/mce: Clear a useless global variable in mce.c

2014-05-18 Thread Chen Yucong
On Sat, 2014-05-17 at 11:58 +0200, Borislav Petkov wrote: > On Sat, May 17, 2014 at 04:45:24PM +0800, Chen Yucong wrote: > > This patch is just used to remove a useless global variable mce_entry > > and relative operations in mce.c. > > Well, I can see from the diff below what you're saying here b

Re: [PATCH] x86/mce: Clear a useless global variable in mce.c

2014-05-17 Thread Borislav Petkov
On Sat, May 17, 2014 at 04:45:24PM +0800, Chen Yucong wrote: > This patch is just used to remove a useless global variable mce_entry > and relative operations in mce.c. Well, I can see from the diff below what you're saying here but a commit message should contain information which explains *why*