Re: [PATCH] x86/Kconfig: Further simplify the NR_CPUS config

2018-02-11 Thread Ingo Molnar
* Linus Torvalds wrote: > But regardless, that least version looks perfectly fine to me even > without that random tweak. Thanks, I turned this into: Acked-by: Linus Torvalds Ingo

Re: [PATCH] x86/Kconfig: Further simplify the NR_CPUS config

2018-02-11 Thread Ingo Molnar
* Randy Dunlap wrote: > On 02/10/2018 02:19 PM, Linus Torvalds wrote: > > Looks good to me. > > > > At the risk of bike-shedding, we could remove all the > > > > default1 if !SMP > > > > from the BEGIN/END/DEFAULT things, and perhaps just keep that part in > > NR_CPUS. > > > > I

Re: [PATCH] x86/Kconfig: Further simplify the NR_CPUS config

2018-02-10 Thread Randy Dunlap
On 02/10/2018 02:19 PM, Linus Torvalds wrote: > Looks good to me. > > At the risk of bike-shedding, we could remove all the > > default1 if !SMP > > from the BEGIN/END/DEFAULT things, and perhaps just keep that part in NR_CPUS. > > I didn't check, but I *think* it would work to just

Re: [PATCH] x86/Kconfig: Further simplify the NR_CPUS config

2018-02-10 Thread Linus Torvalds
Looks good to me. At the risk of bike-shedding, we could remove all the default1 if !SMP from the BEGIN/END/DEFAULT things, and perhaps just keep that part in NR_CPUS. I didn't check, but I *think* it would work to just do config NR_CPUS int "Maximum number of CPUs" if SMP

Re: [PATCH] x86/Kconfig: Further simplify the NR_CPUS config

2018-02-10 Thread Randy Dunlap
On 02/10/2018 03:38 AM, Ingo Molnar wrote: > >> Cc: Linus Torvalds >> Signed-off-by: Ingo Molnar >> --- >> arch/x86/Kconfig | 66 >> +-- >> 1 file changed, 40 insertions(+), 26 deletions(-) > > Here is a full combo patch of your patch and

Re: [PATCH] x86/Kconfig: Further simplify the NR_CPUS config

2018-02-10 Thread Ingo Molnar
* Ingo Molnar wrote: > => > Subject: x86/Kconfig: Further simplify the NR_CPUS config > From: Ingo Molnar > Date: Sat Feb 10 11:51:57 CET 2018 > > Clean up various aspects of the x86 CONFIG_NR_CPUS configuration switches: > > - Rename the three CONFIG_NR_CPUS related v