Re: [PATCH] x86, pat: Add comments to cachemode translation tables

2015-08-03 Thread Toshi Kani
On Sun, 2015-08-02 at 12:07 +0200, Thomas Gleixner wrote: > On Thu, 23 Jul 2015, Toshi Kani wrote: > > On Thu, 2015-07-23 at 09:36 -0600, Jan Beulich wrote: > > > > > > > > > > On 23.07.15 at 17:25, wrote: > > > > Yes, I agree with you. But such risk is very low -- 1) the regular > > > > case >

Re: [PATCH] x86, pat: Add comments to cachemode translation tables

2015-08-02 Thread Thomas Gleixner
On Thu, 23 Jul 2015, Toshi Kani wrote: > On Thu, 2015-07-23 at 09:36 -0600, Jan Beulich wrote: > > > > > > > > On 23.07.15 at 17:25, wrote: > > > Yes, I agree with you. But such risk is very low -- 1) the regular > > > case > > > (no fallback) is used most of the cases, 2) the code using WT kno

Re: [PATCH] x86, pat: Add comments to cachemode translation tables

2015-07-23 Thread Toshi Kani
On Thu, 2015-07-23 at 09:36 -0600, Jan Beulich wrote: > > > > > > On 23.07.15 at 17:25, wrote: > > Yes, I agree with you. But such risk is very low -- 1) the regular > > case > > (no fallback) is used most of the cases, 2) the code using WT knows > > what > > type of memory it is dealing with.

Re: [PATCH] x86, pat: Add comments to cachemode translation tables

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 17:25, wrote: > Yes, I agree with you. But such risk is very low -- 1) the regular case > (no fallback) is used most of the cases, 2) the code using WT knows what > type of memory it is dealing with. For example, pmem may map NVDIMM with > WT, and any sane BIOS sets MTRR to WB

Re: [PATCH] x86, pat: Add comments to cachemode translation tables

2015-07-23 Thread Toshi Kani
On Thu, 2015-07-23 at 08:50 -0600, Jan Beulich wrote: > > > > > > On 23.07.15 at 16:27, wrote: > > On Thu, 2015-07-23 at 00:42 -0600, Jan Beulich wrote: > > > > > > > > > > On 22.07.15 at 20:06, wrote: > > > > Add comments to the cachemode translation tables to clarify that > > > > the default

Re: [PATCH] x86, pat: Add comments to cachemode translation tables

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 16:27, wrote: > On Thu, 2015-07-23 at 00:42 -0600, Jan Beulich wrote: >> > >> > > > On 22.07.15 at 20:06, wrote: >> > Add comments to the cachemode translation tables to clarify that >> > the default values are set as minimal supported mode, which are >> > necessary to handle

Re: [PATCH] x86, pat: Add comments to cachemode translation tables

2015-07-23 Thread Toshi Kani
On Thu, 2015-07-23 at 00:42 -0600, Jan Beulich wrote: > > > > > > On 22.07.15 at 20:06, wrote: > > Add comments to the cachemode translation tables to clarify that > > the default values are set as minimal supported mode, which are > > necessary to handle WC and WT fallback to UC- when they are n

Re: [PATCH] x86, pat: Add comments to cachemode translation tables

2015-07-22 Thread Jan Beulich
>>> On 22.07.15 at 20:06, wrote: > Add comments to the cachemode translation tables to clarify that > the default values are set as minimal supported mode, which are > necessary to handle WC and WT fallback to UC- when they are not > enabled. Wait - shouldn't WT fall back to UC (so to not be affe