Re: [PATCH] x86, crypto: Check if gas supports CRC32

2014-07-30 Thread Mathias Krause
On 31 July 2014 00:11, Borislav Petkov wrote: > > On Wed, Jul 30, 2014 at 11:28:14PM +0200, Mathias Krause wrote: > > Gah, CONFIG_AS_CRC32 gets defined as a preprocessor symbol only so > > cannot be used in makefiles. So crc32c-pcl-intel-asm_64.S needs a > > "#ifdef CONFIG_AS_CRC32" guard and stil

Re: [PATCH] x86, crypto: Check if gas supports CRC32

2014-07-30 Thread Borislav Petkov
On Wed, Jul 30, 2014 at 11:28:14PM +0200, Mathias Krause wrote: > Gah, CONFIG_AS_CRC32 gets defined as a preprocessor symbol only so > cannot be used in makefiles. So crc32c-pcl-intel-asm_64.S needs a > "#ifdef CONFIG_AS_CRC32" guard and still be compiled for CONFIG_64BIT, > as it is now. It'll be

Re: [PATCH] x86, crypto: Check if gas supports CRC32

2014-07-30 Thread Mathias Krause
On Wed, Jul 30, 2014 at 11:19:37PM +0200, Mathias Krause wrote: > On Wed, Jul 30, 2014 at 06:47:01PM +0200, Borislav Petkov wrote: > > [...] > > This looks too complicated. We do have as-instr for exactly those kind > of tests. And, in fact, looking at arch/x86/Makefile we already have one > for c

Re: [PATCH] x86, crypto: Check if gas supports CRC32

2014-07-30 Thread Mathias Krause
On Wed, Jul 30, 2014 at 06:47:01PM +0200, Borislav Petkov wrote: > Building current kernel with some old toolchain (gcc 4.1.2 and gas 2.17) > chokes with: > > arch/x86/crypto/crc32c-pcl-intel-asm_64.S: Assembler messages: > arch/x86/crypto/crc32c-pcl-intel-asm_64.S:128: Error: no such instruction: