Re: [PATCH] x86, boot: access cmdline when loaded high

2013-06-12 Thread Kees Cook
On Tue, Jun 11, 2013 at 1:54 PM, Yinghai Lu wrote: > On Tue, Jun 11, 2013 at 12:26 PM, Kees Cook wrote: >> On Tue, Jun 11, 2013 at 12:17 PM, Yinghai Lu wrote: >>> On Tue, Jun 11, 2013 at 11:41 AM, Kees Cook wrote: The __cmdline_find_option routine requires that the kernel cmdline be l

Re: [PATCH] x86, boot: access cmdline when loaded high

2013-06-11 Thread Yinghai Lu
On Tue, Jun 11, 2013 at 1:54 PM, Yinghai Lu wrote: >> >>> Before the patch, command line that is loaded high >>> can be processed correctly in arch/x86/boot/compressed/cmdline.c. >> >> It can't. Here is the code from arch/x86/boot/cmdline.c: > > Are you sure? > > I tested that with kexec loaded se

Re: [PATCH] x86, boot: access cmdline when loaded high

2013-06-11 Thread Yinghai Lu
On Tue, Jun 11, 2013 at 12:26 PM, Kees Cook wrote: > On Tue, Jun 11, 2013 at 12:17 PM, Yinghai Lu wrote: >> On Tue, Jun 11, 2013 at 11:41 AM, Kees Cook wrote: >>> The __cmdline_find_option routine requires that the kernel cmdline be >>> located under 0x1. When running the compressed boot cod

Re: [PATCH] x86, boot: access cmdline when loaded high

2013-06-11 Thread Kees Cook
On Tue, Jun 11, 2013 at 12:17 PM, Yinghai Lu wrote: > On Tue, Jun 11, 2013 at 11:41 AM, Kees Cook wrote: >> The __cmdline_find_option routine requires that the kernel cmdline be >> located under 0x1. When running the compressed boot code, if the >> cmdline is loaded above this range, it will

Re: [PATCH] x86, boot: access cmdline when loaded high

2013-06-11 Thread Yinghai Lu
On Tue, Jun 11, 2013 at 11:41 AM, Kees Cook wrote: > The __cmdline_find_option routine requires that the kernel cmdline be > located under 0x1. When running the compressed boot code, if the > cmdline is loaded above this range, it will be ignored. This breaks > recognition of things like "earl