Re: [PATCH] writeback: tracing: Copy only up to 31 characters in strncpy() calls

2019-01-31 Thread Mathieu Malaterre
Nick, On Fri, Jan 25, 2019 at 6:06 PM Kees Cook wrote: > > On Fri, Jan 25, 2019 at 9:18 PM Mathieu Malaterre wrote: > > > > On Fri, Jan 25, 2019 at 5:26 AM Nick Desaulniers > > wrote: > > > > > > On Fri, Jan 18, 2019 at 11:32 AM Mathieu Malaterre > > > wrote: > > > > > > > > In the past an at

Re: [PATCH] writeback: tracing: Copy only up to 31 characters in strncpy() calls

2019-01-25 Thread Kees Cook
On Fri, Jan 25, 2019 at 9:18 PM Mathieu Malaterre wrote: > > On Fri, Jan 25, 2019 at 5:26 AM Nick Desaulniers > wrote: > > > > On Fri, Jan 18, 2019 at 11:32 AM Mathieu Malaterre wrote: > > > > > > In the past an attempt was made to remove a set of warnings triggered by > > > gcc 8.x and W=1 by c

Re: [PATCH] writeback: tracing: Copy only up to 31 characters in strncpy() calls

2019-01-25 Thread Mathieu Malaterre
On Fri, Jan 25, 2019 at 5:26 AM Nick Desaulniers wrote: > > On Fri, Jan 18, 2019 at 11:32 AM Mathieu Malaterre wrote: > > > > In the past an attempt was made to remove a set of warnings triggered by > > gcc 8.x and W=1 by changing calls to strncpy() into strlcpy(). This was > > rejected as one of

Re: [PATCH] writeback: tracing: Copy only up to 31 characters in strncpy() calls

2019-01-24 Thread Nick Desaulniers
On Fri, Jan 18, 2019 at 11:32 AM Mathieu Malaterre wrote: > > In the past an attempt was made to remove a set of warnings triggered by > gcc 8.x and W=1 by changing calls to strncpy() into strlcpy(). This was > rejected as one of the desired behavior is to keep initializing the rest > of the desti