Re: [PATCH] writeback: make local functions as static

2013-05-31 Thread Haicheng Li
On Thu, May 30, 2013 at 11:21:21AM +0200, Jan Kara wrote: > On Wed 29-05-13 21:49:38, Haicheng Li wrote: > > Functions not used globally should be static. > I agree for wb_do_writeback(). Ok, thanks. > You definitely shouldn't make > writeback_inodes_sb_nr() static, that it part of generic write

Re: [PATCH] writeback: make local functions as static

2013-05-30 Thread Jan Kara
On Wed 29-05-13 21:49:38, Haicheng Li wrote: > Functions not used globally should be static. I agree for wb_do_writeback(). You definitely shouldn't make writeback_inodes_sb_nr() static, that it part of generic writeback API (although it is currently unused, I agree). I'm somewhat undecided about