Re: [PATCH] wl18xx: Fix Wunused-const-variable

2019-06-24 Thread Kalle Valo
Nathan Huckleberry wrote: > Clang produces the following warning > > drivers/net/wireless/ti/wl18xx/main.c:1850:43: warning: unused variable > 'wl18xx_iface_ap_cl_limits' [-Wunused-const-variable] static const struct > ieee80211_iface_limit wl18xx_iface_ap_cl_limits[] = { ^ > drivers/net/wireles

Re: [PATCH] wl18xx: Fix Wunused-const-variable

2019-06-17 Thread Kalle Valo
Nick Desaulniers writes: > On Fri, Jun 14, 2019 at 10:17 AM 'Nathan Huckleberry' via Clang Built > Linux wrote: >> >> Clang produces the following warning >> >> drivers/net/wireless/ti/wl18xx/main.c:1850:43: warning: unused variable >> 'wl18xx_iface_ap_cl_limits' [-Wunused-const-variable] static

Re: [PATCH] wl18xx: Fix Wunused-const-variable

2019-06-14 Thread Nick Desaulniers
On Fri, Jun 14, 2019 at 1:54 PM Nick Desaulniers wrote: > Looking at drivers/net/wireless/ti/wl18xx/main.c, there 4 globally > declared `struct ieee80211_iface_limit` but as your patch notes, only > 2 are used. The thing is, their uses are in a `struct > ieee80211_iface_limit []`. Sorry, that's

Re: [PATCH] wl18xx: Fix Wunused-const-variable

2019-06-14 Thread Nick Desaulniers
On Fri, Jun 14, 2019 at 10:17 AM 'Nathan Huckleberry' via Clang Built Linux wrote: > > Clang produces the following warning > > drivers/net/wireless/ti/wl18xx/main.c:1850:43: warning: unused variable > 'wl18xx_iface_ap_cl_limits' [-Wunused-const-variable] static const struct > ieee80211_iface_limi