Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-22 Thread Jason Wang
On 2021/2/22 3:29 下午, Michael S. Tsirkin wrote: On Mon, Feb 22, 2021 at 11:42:44AM +0800, Jason Wang wrote: On 2021/2/19 11:38 下午, Guenter Roeck wrote: On 2/19/21 12:45 AM, Jason Wang wrote: We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a lot of confusion. E.g it may bre

Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-21 Thread Michael S. Tsirkin
On Mon, Feb 22, 2021 at 11:42:44AM +0800, Jason Wang wrote: > > On 2021/2/19 11:38 下午, Guenter Roeck wrote: > > On 2/19/21 12:45 AM, Jason Wang wrote: > > > We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a > > > lot of confusion. E.g it may break various default configs which w

Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-21 Thread Jason Wang
On 2021/2/19 11:38 下午, Guenter Roeck wrote: On 2/19/21 12:45 AM, Jason Wang wrote: We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a lot of confusion. E.g it may break various default configs which want virtio devices. So this patch fixes this by hide the prompot and docume

Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-21 Thread Jason Wang
On 2021/2/19 6:12 下午, Arnd Bergmann wrote: On Fri, Feb 19, 2021 at 9:45 AM Jason Wang wrote: We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a lot of confusion. E.g it may break various default configs which want virtio devices. So this patch fixes this by hide the prompot

Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-19 Thread Jason Wang
On 2021/2/19 6:13 下午, Christoph Hellwig wrote: On Fri, Feb 19, 2021 at 03:45:09AM -0500, Jason Wang wrote: We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a lot of confusion. E.g it may break various default configs which want virtio devices. So this patch fixes this by hid

Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-19 Thread Guenter Roeck
On 2/19/21 12:45 AM, Jason Wang wrote: > We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a > lot of confusion. E.g it may break various default configs which want > virtio devices. > > So this patch fixes this by hide the prompot and document the ... by hiding the prompt and do

Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-19 Thread Arnd Bergmann
On Fri, Feb 19, 2021 at 9:45 AM Jason Wang wrote: > > We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a > lot of confusion. E.g it may break various default configs which want > virtio devices. > > So this patch fixes this by hide the prompot and document the > dependency. > > C

Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-19 Thread Christoph Hellwig
On Fri, Feb 19, 2021 at 03:45:09AM -0500, Jason Wang wrote: > We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a > lot of confusion. E.g it may break various default configs which want > virtio devices. > > So this patch fixes this by hide the prompot and document the > dependenc