Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-06-02 Thread Laurent Pinchart
Hi Dafna, On Tue, Jun 02, 2020 at 03:16:03PM +0200, Dafna Hirschfeld wrote: > On 02.06.20 14:45, Laurent Pinchart wrote: > > On Tue, Jun 02, 2020 at 08:31:26AM -0300, Helen Koike wrote: > >> On 6/2/20 8:24 AM, Kieran Bingham wrote: > >>> On 02/06/2020 11:55, Helen Koike wrote: > On 6/2/20 7:5

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-06-02 Thread Dafna Hirschfeld
On 02.06.20 14:45, Laurent Pinchart wrote: Hello, On Tue, Jun 02, 2020 at 08:31:26AM -0300, Helen Koike wrote: On 6/2/20 8:24 AM, Kieran Bingham wrote: On 02/06/2020 11:55, Helen Koike wrote: On 6/2/20 7:52 AM, Dafna Hirschfeld wrote: On 01.06.20 14:16, Kaaira Gupta wrote: On Fri, May 29

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-06-02 Thread Helen Koike
On 6/2/20 9:45 AM, Laurent Pinchart wrote: > Hello, > > On Tue, Jun 02, 2020 at 08:31:26AM -0300, Helen Koike wrote: >> On 6/2/20 8:24 AM, Kieran Bingham wrote: >>> On 02/06/2020 11:55, Helen Koike wrote: On 6/2/20 7:52 AM, Dafna Hirschfeld wrote: > On 01.06.20 14:16, Kaaira Gupta wrot

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-06-02 Thread Laurent Pinchart
Hello, On Tue, Jun 02, 2020 at 08:31:26AM -0300, Helen Koike wrote: > On 6/2/20 8:24 AM, Kieran Bingham wrote: > > On 02/06/2020 11:55, Helen Koike wrote: > >> On 6/2/20 7:52 AM, Dafna Hirschfeld wrote: > >>> On 01.06.20 14:16, Kaaira Gupta wrote: > On Fri, May 29, 2020 at 05:43:57PM +0200, D

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-06-02 Thread Helen Koike
Hello, On 6/2/20 8:24 AM, Kieran Bingham wrote: > Hi Helen, Dafna, > > On 02/06/2020 11:55, Helen Koike wrote: >> >> On 6/2/20 7:52 AM, Dafna Hirschfeld wrote: >>> >>> On 01.06.20 14:16, Kaaira Gupta wrote: On Fri, May 29, 2020 at 05:43:57PM +0200, Dafna Hirschfeld wrote: > Hi, > Tha

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-06-02 Thread Kieran Bingham
Hi Helen, Dafna, On 02/06/2020 11:55, Helen Koike wrote: > > On 6/2/20 7:52 AM, Dafna Hirschfeld wrote: >> >> On 01.06.20 14:16, Kaaira Gupta wrote: >>> On Fri, May 29, 2020 at 05:43:57PM +0200, Dafna Hirschfeld wrote: Hi, Thanks for the patch I don't know how real devices han

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-06-02 Thread Helen Koike
On 6/2/20 7:52 AM, Dafna Hirschfeld wrote: > > > On 01.06.20 14:16, Kaaira Gupta wrote: >> On Fri, May 29, 2020 at 05:43:57PM +0200, Dafna Hirschfeld wrote: >>> Hi, >>> Thanks for the patch >>> >>> I don't know how real devices handle ARGB formats, >>> I wonder if it should be the part of the

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-06-02 Thread Dafna Hirschfeld
On 01.06.20 14:16, Kaaira Gupta wrote: On Fri, May 29, 2020 at 05:43:57PM +0200, Dafna Hirschfeld wrote: Hi, Thanks for the patch I don't know how real devices handle ARGB formats, I wonder if it should be the part of the debayer. Hi! qcam tries to support BA24 as it is one of the formats

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-06-01 Thread Helen Koike
On 6/1/20 9:37 AM, Laurent Pinchart wrote: > On Mon, Jun 01, 2020 at 05:46:26PM +0530, Kaaira Gupta wrote: >> On Fri, May 29, 2020 at 05:43:57PM +0200, Dafna Hirschfeld wrote: >>> Hi, >>> Thanks for the patch >>> >>> I don't know how real devices handle ARGB formats, >>> I wonder if it should be

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-06-01 Thread Laurent Pinchart
On Mon, Jun 01, 2020 at 05:46:26PM +0530, Kaaira Gupta wrote: > On Fri, May 29, 2020 at 05:43:57PM +0200, Dafna Hirschfeld wrote: > > Hi, > > Thanks for the patch > > > > I don't know how real devices handle ARGB formats, > > I wonder if it should be the part of the debayer. > > Hi! qcam tries to

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-05-29 Thread Dafna Hirschfeld
Hi, Thanks for the patch I don't know how real devices handle ARGB formats, I wonder if it should be the part of the debayer. On 28.05.20 20:57, Kaaira Gupta wrote: Running qcam for pixelformat 0x34324142 showed that vimc debayer does not support it. Hence, add the support for Alpha (255). I