Re: [PATCH] vfs: remove the unnecessrary code of fs/inode.c

2013-07-01 Thread Dong Fang
On 07/02/2013 02:11 AM, Dong Fang wrote: On 07/02/2013 12:41 AM, Al Viro wrote: On Mon, Jul 01, 2013 at 08:19:03AM -0400, Dong Fang wrote: These functions, such as find_inode_fast() and find_inode(), iget_lock() and iget5_lock(), insert_inode_locked() and insert_inode_locked4(), almost have the

Re: [PATCH] vfs: remove the unnecessrary code of fs/inode.c

2013-07-01 Thread Dong Fang
On 07/02/2013 12:41 AM, Al Viro wrote: On Mon, Jul 01, 2013 at 08:19:03AM -0400, Dong Fang wrote: These functions, such as find_inode_fast() and find_inode(), iget_lock() and iget5_lock(), insert_inode_locked() and insert_inode_locked4(), almost have the same code. NAK. These functions exist

Re: [PATCH] vfs: remove the unnecessrary code of fs/inode.c

2013-07-01 Thread Dong Fang
On 07/02/2013 12:15 AM, Gu Zheng wrote: On 07/01/2013 08:19 PM, Dong Fang wrote: These functions, such as find_inode_fast() and find_inode(), iget_lock() and iget5_lock(), insert_inode_locked() and insert_inode_locked4(), almost have the same code. Maybe the title "[PATCH] vfs: remove the red

Re: [PATCH] vfs: remove the unnecessrary code of fs/inode.c

2013-07-01 Thread Al Viro
On Mon, Jul 01, 2013 at 08:19:03AM -0400, Dong Fang wrote: > These functions, such as find_inode_fast() and find_inode(), iget_lock() and > iget5_lock(), insert_inode_locked() and insert_inode_locked4(), almost have > the same code. NAK. These functions exist exactly because the variant with call

Re: [PATCH] vfs: remove the unnecessrary code of fs/inode.c

2013-07-01 Thread Gu Zheng
On 07/01/2013 08:19 PM, Dong Fang wrote: > These functions, such as find_inode_fast() and find_inode(), iget_lock() and > iget5_lock(), insert_inode_locked() and insert_inode_locked4(), almost have > the same code. Maybe the title "[PATCH] vfs: remove the reduplicate code of fs/inode.c" is more s