Re: [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0 support

2016-05-04 Thread Johan Hovold
On Tue, May 03, 2016 at 01:46:51PM +0200, Mathieu OTHACEHE wrote: > > No, I was trying to say that the we should not attempt to load a > > firmware on the "ti_usb-v%04x-p%04x.fw" format before loading the moxa > > firmware. > > For MTS devices (mts_*.fw) and for devices using generic firmware (ti_

Re: [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0 support

2016-05-03 Thread Mathieu OTHACEHE
> No, I was trying to say that the we should not attempt to load a > firmware on the "ti_usb-v%04x-p%04x.fw" format before loading the moxa > firmware. For MTS devices (mts_*.fw) and for devices using generic firmware (ti_3410.fw and ti_5052.fw), ti_usb-v%04x-p%04x.fw loading is already failing.

Re: [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0 support

2016-05-03 Thread Johan Hovold
On Mon, May 02, 2016 at 08:37:15PM +0200, Mathieu OTHACEHE wrote: > Hi Johan, > > Thanks for your review. > > > Looks like this code could use a few vid/pid temporaries. > > > I'm not sure it makes sense to try to load a "ti_usb-v110a-p1150.fw" > > firmware before requesting the moxa firmware. A

Re: [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0 support

2016-04-24 Thread Johan Hovold
On Wed, Mar 02, 2016 at 10:46:13AM +0100, Mathieu OTHACEHE wrote: > Add support for : > > - UPort 1110 : 1 port RS-232 USB to Serial Hub. > - UPort 1130 : 1 port RS-422/485 USB to Serial Hub. > - UPort 1130I : 1 port RS-422/485 USB to Serial Hub with Isolation. > - UPort 1150 : 1 port RS-232/42