Re: [PATCH] uml: fix W=1 missing-include-dirs warnings

2021-04-15 Thread Randy Dunlap
On 4/15/21 12:04 AM, Masahiro Yamada wrote: > On Thu, Apr 15, 2021 at 4:02 PM Randy Dunlap wrote: >> >> On 4/14/21 11:52 PM, Masahiro Yamada wrote: >>> On Thu, Apr 15, 2021 at 4:27 AM Randy Dunlap wrote: Currently when using "W=1" with UML builds, there are over 700 warnings like s

Re: [PATCH] uml: fix W=1 missing-include-dirs warnings

2021-04-15 Thread Masahiro Yamada
On Thu, Apr 15, 2021 at 4:02 PM Randy Dunlap wrote: > > On 4/14/21 11:52 PM, Masahiro Yamada wrote: > > On Thu, Apr 15, 2021 at 4:27 AM Randy Dunlap wrote: > >> > >> Currently when using "W=1" with UML builds, there are over 700 warnings > >> like so: > >> > >> CC arch/um/drivers/stderr_co

Re: [PATCH] uml: fix W=1 missing-include-dirs warnings

2021-04-15 Thread Randy Dunlap
On 4/14/21 11:52 PM, Masahiro Yamada wrote: > On Thu, Apr 15, 2021 at 4:27 AM Randy Dunlap wrote: >> >> Currently when using "W=1" with UML builds, there are over 700 warnings >> like so: >> >> CC arch/um/drivers/stderr_console.o >> cc1: warning: ./arch/um/include/uapi: No such file or dire

Re: [PATCH] uml: fix W=1 missing-include-dirs warnings

2021-04-14 Thread Masahiro Yamada
On Thu, Apr 15, 2021 at 4:27 AM Randy Dunlap wrote: > > Currently when using "W=1" with UML builds, there are over 700 warnings > like so: > > CC arch/um/drivers/stderr_console.o > cc1: warning: ./arch/um/include/uapi: No such file or directory > [-Wmissing-include-dirs] > > but arch/um/ d

Re: [PATCH] uml: remove unneeded variable 'ret'

2021-03-10 Thread Johannes Berg
On Wed, 2021-03-10 at 16:49 +0800, Yang Li wrote: > Fix the following coccicheck warning: > ./arch/um/drivers/hostaudio_kern.c:125:10-14: Unneeded variable: "mask". > Return "0" on line 131 Word of caution to you: You've already managed to be in various people's block list due to sending patches

Re: [PATCH] UML: don't discard .text.exit section

2016-08-23 Thread Richard Weinberger
On 23.08.2016 11:59, Andrey Ryabinin wrote: >> Andrey, shall I carry this patch through the UML tree or >> do you have something else in mind? >> > > Take it in the UML tree please. Ok! Applied to -next. Thanks, //richard

Re: [PATCH] UML: don't discard .text.exit section

2016-08-23 Thread Andrey Ryabinin
On 08/22/2016 11:10 PM, Richard Weinberger wrote: > On 19.08.2016 17:24, Dmitry Vyukov wrote: >> If it exits then >> >> Acked-by: Dmitry Vyukov > > Andrey, shall I carry this patch through the UML tree or > do you have something else in mind? > Take it in the UML tree please. > Thanks, > //r

Re: [PATCH] UML: don't discard .text.exit section

2016-08-22 Thread Richard Weinberger
On 19.08.2016 17:24, Dmitry Vyukov wrote: > If it exits then > > Acked-by: Dmitry Vyukov Andrey, shall I carry this patch through the UML tree or do you have something else in mind? Thanks, //richard

Re: [PATCH] UML: don't discard .text.exit section

2016-08-19 Thread Andrey Ryabinin
On 08/19/2016 02:16 PM, Richard Weinberger wrote: > On 19.08.2016 12:48, Andrey Ryabinin wrote: >> On 08/19/2016 03:14 AM, Dmitry Vyukov wrote: >>> On Thu, Aug 18, 2016 at 3:08 AM, Andrey Ryabinin >>> wrote: > > Sorry for delays, I am travelling. > Do we need ".fini_array" secti

Re: [PATCH] UML: don't discard .text.exit section

2016-08-19 Thread Dmitry Vyukov
On Fri, Aug 19, 2016 at 6:06 AM, Andrey Ryabinin wrote: > > > On 08/19/2016 02:16 PM, Richard Weinberger wrote: >> On 19.08.2016 12:48, Andrey Ryabinin wrote: >>> On 08/19/2016 03:14 AM, Dmitry Vyukov wrote: On Thu, Aug 18, 2016 at 3:08 AM, Andrey Ryabinin wrote: > >> >> Sor

Re: [PATCH] UML: don't discard .text.exit section

2016-08-19 Thread Richard Weinberger
On 19.08.2016 12:48, Andrey Ryabinin wrote: > On 08/19/2016 03:14 AM, Dmitry Vyukov wrote: >> On Thu, Aug 18, 2016 at 3:08 AM, Andrey Ryabinin >> wrote: >>> Sorry for delays, I am travelling. Do we need ".fini_array" section? It's also destructors that we don't run. Or does UML

Re: [PATCH] UML: don't discard .text.exit section

2016-08-19 Thread Andrey Ryabinin
On 08/19/2016 03:14 AM, Dmitry Vyukov wrote: > On Thu, Aug 18, 2016 at 3:08 AM, Andrey Ryabinin > wrote: >> >>> >>> Sorry for delays, I am travelling. >>> Do we need ".fini_array" section? It's also destructors that we don't >>> run. Or does UML use them? Does discarding ".fini_array" help? >>> >>

Re: [PATCH] UML: don't discard .text.exit section

2016-08-18 Thread Dmitry Vyukov
On Thu, Aug 18, 2016 at 3:08 AM, Andrey Ryabinin wrote: > > > On 08/17/2016 08:11 PM, Dmitry Vyukov wrote: >> On Wed, Aug 17, 2016 at 8:10 AM, Andrey Ryabinin >> wrote: >>> Commit e41f501d3912 ("vmlinux.lds: account for destructor sections") >>> added '.text.exit' to EXIT_TEXT which is discarded

Re: [PATCH] UML: don't discard .text.exit section

2016-08-18 Thread Andrey Ryabinin
On 08/17/2016 08:11 PM, Dmitry Vyukov wrote: > On Wed, Aug 17, 2016 at 8:10 AM, Andrey Ryabinin > wrote: >> Commit e41f501d3912 ("vmlinux.lds: account for destructor sections") >> added '.text.exit' to EXIT_TEXT which is discarded at link time by default. >> This breaks compilation of UML: >>

Re: [PATCH] UML: don't discard .text.exit section

2016-08-17 Thread Dmitry Vyukov
On Wed, Aug 17, 2016 at 8:10 AM, Andrey Ryabinin wrote: > Commit e41f501d3912 ("vmlinux.lds: account for destructor sections") > added '.text.exit' to EXIT_TEXT which is discarded at link time by default. > This breaks compilation of UML: > `.text.exit' referenced in section `.fini_array' of

Re: [PATCH] uml: fix hostfs mknod()

2015-12-16 Thread Vegard Nossum
On 12/16/2015 11:17 PM, Richard Weinberger wrote: Am 16.12.2015 um 21:59 schrieb Vegard Nossum: An inverted return value check in hostfs_mknod() caused the function to return success after handling it as an error (and cleaning up). [...] Applied! :-) BTW: How did you create this patch? I ha

Re: [PATCH] uml: fix hostfs mknod()

2015-12-16 Thread Richard Weinberger
Am 16.12.2015 um 21:59 schrieb Vegard Nossum: > An inverted return value check in hostfs_mknod() caused the function > to return success after handling it as an error (and cleaning up). > > It resulted in the following segfault when trying to bind() a named > unix socket: > > Pid: 198, comm: a.

Re: [PATCH] UML: UBD: Fix for processes stuck in D state forever in UserModeLinux

2014-09-16 Thread Richard Weinberger
On Mon, Aug 25, 2014 at 4:04 PM, Richard Weinberger wrote: > Am 25.08.2014 16:00, schrieb Thorsten Knabe: >> On 08/25/2014 03:25 PM, Richard Weinberger wrote: >>> Am 25.08.2014 01:02, schrieb Thorsten Knabe: On 08/24/2014 02:11 PM, Richard Weinberger wrote: > Am 23.08.2014 19:43, schrieb

Re: [PATCH] UML: UBD: Fix for processes stuck in D state forever in UserModeLinux

2014-08-25 Thread Richard Weinberger
Am 25.08.2014 16:00, schrieb Thorsten Knabe: > On 08/25/2014 03:25 PM, Richard Weinberger wrote: >> Am 25.08.2014 01:02, schrieb Thorsten Knabe: >>> On 08/24/2014 02:11 PM, Richard Weinberger wrote: Am 23.08.2014 19:43, schrieb Thorsten Knabe: > Hi Richard. > > On 08/23/2014 05:34

Re: [PATCH] UML: UBD: Fix for processes stuck in D state forever in UserModeLinux

2014-08-25 Thread Thorsten Knabe
On 08/25/2014 03:25 PM, Richard Weinberger wrote: > Am 25.08.2014 01:02, schrieb Thorsten Knabe: >> On 08/24/2014 02:11 PM, Richard Weinberger wrote: >>> Am 23.08.2014 19:43, schrieb Thorsten Knabe: Hi Richard. On 08/23/2014 05:34 PM, Richard Weinberger wrote: > Hi! > > A

Re: [PATCH] UML: UBD: Fix for processes stuck in D state forever in UserModeLinux

2014-08-25 Thread Richard Weinberger
Am 25.08.2014 01:02, schrieb Thorsten Knabe: > On 08/24/2014 02:11 PM, Richard Weinberger wrote: >> Am 23.08.2014 19:43, schrieb Thorsten Knabe: >>> Hi Richard. >>> >>> On 08/23/2014 05:34 PM, Richard Weinberger wrote: Hi! Am 23.08.2014 15:47, schrieb Thorsten Knabe: > From: Thor

Re: [PATCH] UML: UBD: Fix for processes stuck in D state forever in UserModeLinux

2014-08-24 Thread Thorsten Knabe
On 08/24/2014 02:11 PM, Richard Weinberger wrote: > Am 23.08.2014 19:43, schrieb Thorsten Knabe: >> Hi Richard. >> >> On 08/23/2014 05:34 PM, Richard Weinberger wrote: >>> Hi! >>> >>> Am 23.08.2014 15:47, schrieb Thorsten Knabe: From: Thorsten Knabe UML: UBD: Fix for processes stuck

Re: [PATCH] UML: UBD: Fix for processes stuck in D state forever in UserModeLinux

2014-08-24 Thread Richard Weinberger
Am 23.08.2014 19:43, schrieb Thorsten Knabe: > Hi Richard. > > On 08/23/2014 05:34 PM, Richard Weinberger wrote: >> Hi! >> >> Am 23.08.2014 15:47, schrieb Thorsten Knabe: >>> From: Thorsten Knabe >>> >>> UML: UBD: Fix for processes stuck in D state forever in UserModeLinux. >>> >>> Starting with

Re: [PATCH] UML: UBD: Fix for processes stuck in D state forever in UserModeLinux

2014-08-23 Thread Thorsten Knabe
Hi Richard. On 08/23/2014 05:34 PM, Richard Weinberger wrote: > Hi! > > Am 23.08.2014 15:47, schrieb Thorsten Knabe: >> From: Thorsten Knabe >> >> UML: UBD: Fix for processes stuck in D state forever in UserModeLinux. >> >> Starting with Linux 3.12 processes get stuck in D state forever in >> Us

Re: [PATCH] UML: UBD: Fix for processes stuck in D state forever in UserModeLinux

2014-08-23 Thread Richard Weinberger
Hi! Am 23.08.2014 15:47, schrieb Thorsten Knabe: > From: Thorsten Knabe > > UML: UBD: Fix for processes stuck in D state forever in UserModeLinux. > > Starting with Linux 3.12 processes get stuck in D state forever in > UserModeLinux under sync heavy workloads. This bug was introduced by > comm

Re: [PATCH] uml/net_kern: Eliminate NULL test after alloc_bootmem

2014-07-23 Thread Richard Weinberger
Himangi, Am 19.07.2014 13:34, schrieb Himangi Saraogi: > alloc_bootmem and related functions never return NULL. Thus a NULL > test or memset after calls to these functions is unnecessary. > > The following Coccinelle semantic patch was used for making the change: > > @@ > expression E; > stateme

Re: [PATCH] uml: Simplify tempdir logic.

2013-11-17 Thread Richard Weinberger
Am 11.11.2013 19:03, schrieb Tristan Schmelcher: > From: Tristan Schmelcher > > Inferring the mount hierarchy correctly from /proc/mounts is hard when MS_MOVE > may have been used, and the previous code did it wrongly. This change > simplifies > the logic to only require that /dev/shm be _on_ tm

Re: [PATCH] uml: Fix which_tmpdir failure when /dev/shm is a symlink, and in other edge cases

2013-06-19 Thread Tristan Schmelcher
And of course I found a bug in it moments after sending. Please ignore, v2 coming shortly. On 19 June 2013 15:30, Tristan Schmelcher wrote: > From: Tristan Schmelcher > > which_tmpdir did the wrong thing if /dev/shm was a symlink (e.g., to > /run/shm), if there were multiple mounts on top of eac

Re: [PATCH] UML - update defconfig

2008-02-07 Thread Christoph Hellwig
On Thu, Feb 07, 2008 at 11:53:59AM -0500, Jeff Dike wrote: > [ This is 2.6.25 fodder ] > > Update defconfig. > > Cc: Christoph Hellwig <[EMAIL PROTECTED]> > Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bod

Re: [PATCH] uml: handle unusual results from find_tempdir.

2008-02-05 Thread Jeff Dike
On Tue, Feb 05, 2008 at 05:25:06PM +0100, Jim Meyering wrote: > > An alternative: make find_tempdir set tempdir to default_tempdir > upon malloc failure. > > * arch/um/os-Linux/mem.c (make_tempfile): Handle NULL tempdir. > Don't let a long tempdir (e.g., via TMPDIR) provoke heap corruption. > >

Re: [PATCH] uml: user of helper_wait() got missed when it got extra arguments

2008-01-02 Thread Jeff Dike
On Sun, Dec 23, 2007 at 08:01:04PM +, Al Viro wrote: > - helper_wait(pid); > + helper_wait(pid, 1, NULL); Thanks. I know I fixed these - I probably forgot to quilt add the file. Jeff -- Work email - jdike at linux dot intel dot com --

Re: [PATCH] UML - Add asm/fixmap.h include

2007-12-14 Thread Jeff Dike
On Fri, Dec 14, 2007 at 09:58:40AM -0800, Andrew Morton wrote: > arch/um/include/um_uaccess.h already includes fixmap.h. Is this a -mm-only > fix? Whoops, it is. The include was removed by uml-header-untangling.patch, so folding this into that would work. Jeff -

Re: [PATCH] UML - Add asm/fixmap.h include

2007-12-14 Thread Andrew Morton
On Fri, 14 Dec 2007 11:16:47 -0500 Jeff Dike <[EMAIL PROTECTED]> wrote: > [ This needs to go into 2.6.24, as it fixes a build breakage seen on x86_64 ] > > um_uaccess.h refers to FIXADDR_USER_*, so it should include fixmap.h. > > I also changed the non-UML includes to use <> instead of "". > >

Re: [PATCH] UML - change sigcontext fields to match x86

2007-12-05 Thread Ingo Molnar
* Jeff Dike <[EMAIL PROTECTED]> wrote: > On Wed, Dec 05, 2007 at 05:48:16PM +0100, Ingo Molnar wrote: > > thanks, we indeed missed those. Should we carry this in x86.git, or > > would you like to carry this in your UML tree? > > Probably better for it to go in x86.git - that way it travels with

Re: [PATCH] UML - change sigcontext fields to match x86

2007-12-05 Thread Jeff Dike
On Wed, Dec 05, 2007 at 05:48:16PM +0100, Ingo Molnar wrote: > thanks, we indeed missed those. Should we carry this in x86.git, or > would you like to carry this in your UML tree? Probably better for it to go in x86.git - that way it travels with your sigcontext patch.

Re: [PATCH] UML - change sigcontext fields to match x86

2007-12-05 Thread Ingo Molnar
* Jeff Dike <[EMAIL PROTECTED]> wrote: > git-x86, in commit 70aa1bd3839e3ec74ce65316528a82570e8de666, changed a > lot of the sigcontext field names. This patch changes UML usage to > match. thanks, we indeed missed those. Should we carry this in x86.git, or would you like to carry this in yo

Re: [PATCH] UML - Fix !NO_HZ busy-loop

2007-11-27 Thread Jeff Dike
On Tue, Nov 27, 2007 at 03:01:08PM -0800, Andrew Morton wrote: > > +#ifdef UML_CONFIG_NO_HZ > > Nothing ever defines this? $ grep HZ obj/arch/um/include/uml-config.h #define UML_CONFIG_NO_HZ 1 uml-config.h is auto-generated to provide the config definitions to the userspace side of UML.

Re: [PATCH] UML - Fix !NO_HZ busy-loop

2007-11-27 Thread Andrew Morton
On Tue, 27 Nov 2007 15:03:47 -0500 Jeff Dike <[EMAIL PROTECTED]> wrote: > [ This one needs to get into 2.6.24 ] > > With NO_HZ disabled, the UML idle loop effectively becomes a busy > loop, as it will sleep for no time. > > The cause was forgetting to restart the tick after waking up from > slee

Re: [PATCH] UML - Fix locking in skb alloction failure fix

2007-09-28 Thread Jeff Dike
On Fri, Sep 28, 2007 at 11:26:34AM -0700, Andrew Morton wrote: > Doesn't this assume that the arch is only ever uniprocessor, which I > don't think is true on i386 UML?? It is for now, and when that changes, I haven't decided if and when interrupts will be received on multiple CPUs.

Re: [PATCH] UML - Fix locking in skb alloction failure fix

2007-09-28 Thread Andrew Morton
On Fri, 28 Sep 2007 11:43:14 -0400 Jeff Dike <[EMAIL PROTECTED]> wrote: > Add _irqsave/_irqrestore to the locking in update_drop_skb to keep > uml_net_rx out while the drop skb is being messed with. > > Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> > --- > arch/um/drivers/net_kern.c |5 +++--

Re: [PATCH] UML - Correctly handle skb allocation failures

2007-09-27 Thread Jeff Dike
On Thu, Sep 27, 2007 at 04:53:40PM -0700, Andrew Morton wrote: > Still wanna know why it is safe for uml_net_rx to be playing with > drop_skb when update_drop_skb() could be concurrently reallocating > and freeing it. Ah, yes, I missed that point in the horror of my botch last night. I'll add irq

Re: [PATCH] UML - Correctly handle skb allocation failures

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 13:01:26 -0400 Jeff Dike <[EMAIL PROTECTED]> wrote: > +static int update_drop_skb(int max) > +{ > + struct sk_buff *new; > + int err = 0; > + > + spin_lock(&drop_lock); > + > + if (max <= drop_max) > + goto out; > + > + err = -ENOMEM; > + new

Re: [PATCH] UML - time build fix

2007-09-25 Thread Thomas Gleixner
Jeff, On Tue, 2007-09-25 at 17:56 -0400, Jeff Dike wrote: > On Tue, Sep 25, 2007 at 09:54:15PM +0200, Thomas Gleixner wrote: > > On Tue, 2007-09-25 at 13:37 -0400, Jeff Dike wrote: > > > Put back an implementation of timeval_to_ns in > > > arch/um/os-Linux/time.c. tglx pointed out in his review o

Re: [PATCH] UML - time build fix

2007-09-25 Thread Jeff Dike
On Tue, Sep 25, 2007 at 09:54:15PM +0200, Thomas Gleixner wrote: > On Tue, 2007-09-25 at 13:37 -0400, Jeff Dike wrote: > > Put back an implementation of timeval_to_ns in > > arch/um/os-Linux/time.c. tglx pointed out in his review of tickless > > support that there was a perfectly good implementati

Re: [PATCH] UML - time build fix

2007-09-25 Thread Thomas Gleixner
On Tue, 2007-09-25 at 13:37 -0400, Jeff Dike wrote: > Put back an implementation of timeval_to_ns in > arch/um/os-Linux/time.c. tglx pointed out in his review of tickless > support that there was a perfectly good implementation of it in > linux/time.h. The problem is that this is userspace code

Re: [PATCH] UML - Fix irqstack crash

2007-09-18 Thread Andrew Morton
On Tue, 18 Sep 2007 19:33:36 -0400 Jeff Dike <[EMAIL PROTECTED]> wrote: > === > --- linux-2.6.17.orig/arch/um/os-Linux/signal.c 2007-09-09 > 11:15:37.0 -0400 > +++ linux-2.6.17/arch/um/os-Linux/signal.c2007-09-18 12

Re: [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Jeff Dike
On Thu, Aug 16, 2007 at 10:04:55PM +0200, Sam Ravnborg wrote: > On Thu, Aug 16, 2007 at 03:26:39PM -0400, Jeff Dike wrote: > > > > The crash is in this section: > > > > __uml_setup_start = .; > > .uml.setup.init : { *(.uml.setup.init) } > > __uml_setup_end = .; > > This looks like a classi

Re:[Spam] Re: [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Alberto Pires de Oliveira Neto
Hi Jeff, I'm really sorry, but I forget to mention, that I had the same problems on a RedHat RH4 (x86_64) too. > On Thu, Aug 16, 2007 at 09:30:56AM -0700, Arjan van de Ven wrote: > > this sounds like something really stupid and bad... why would the kernel > > need to have a per-distro note se

Re: [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Sam Ravnborg
On Thu, Aug 16, 2007 at 03:26:39PM -0400, Jeff Dike wrote: > > The crash is in this section: > > __uml_setup_start = .; > .uml.setup.init : { *(.uml.setup.init) } > __uml_setup_end = .; This looks like a classic bug. You wanted this: .uml.setup.init : { __uml_setup_start = .;

Re: [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Jeff Dike
On Thu, Aug 16, 2007 at 09:30:56AM -0700, Arjan van de Ven wrote: > this sounds like something really stupid and bad... why would the kernel > need to have a per-distro note section??? On Thu, Aug 16, 2007 at 09:39:06AM -0700, Chris Wright wrote: > Huh!? Why do we need a SuSE section? On Thu, Au

Re: [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Andi Kleen
Jeff Dike <[EMAIL PROTECTED]> writes: > [ This is both 2.6.24 and -stable material ] > > SuSE seems to require that binaries have a .note.SuSE section. > Without it, UML segfaults if any parameters are passed on the command > line. This doesn't make any sense. You must have misanalyzed this. -A

Re: [PATCH] UML - Add a .note.SuSE section

2007-08-16 Thread Arjan van de Ven
On Thu, 2007-08-16 at 12:24 -0400, Jeff Dike wrote: > [ This is both 2.6.24 and -stable material ] > > SuSE seems to require that binaries have a .note.SuSE section. > Without it, UML segfaults if any parameters are passed on the command > line. this sounds like something really stupid and bad.

Re: [PATCH] UML: BLKGETSIZE takes a long, not an int

2007-08-16 Thread Jeff Dike
On Wed, Aug 15, 2007 at 11:38:25PM +0200, Nicolas George wrote: > Here is the hopefully correct patch, against current git. Thanks, I'll forward it upstream. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "uns

Re: [PATCH] UML - Console should handle spurious IRQS

2007-07-30 Thread Jeff Dike
On Sun, Jul 29, 2007 at 03:50:59AM +0300, Eduard-Gabriel Munteanu wrote: > Jeff Dike wrote: > >The previous DEBUG_SHIRQ patch missed one case. The console doesn't > >set its host descriptors non-blocking. > > Sorry, things looked okay when I tested on my UML environment (Puppy > Linux). Some xte

Re: [PATCH] UML - Console should handle spurious IRQS

2007-07-28 Thread Eduard-Gabriel Munteanu
*This message was transferred with a trial version of CommuniGate(r) Pro* Jeff Dike wrote: The previous DEBUG_SHIRQ patch missed one case. The console doesn't set its host descriptors non-blocking. Sorry, things looked okay when I tested on my UML environment (Puppy Linux). Some xterms popped

Re: [patch] uml: better bugs

2007-06-14 Thread Jeff Dike
On Thu, Jun 14, 2007 at 07:38:33AM +0200, Nick Piggin wrote: > Get UML to use the generic bug support rather than arch specific one. Added to my tree, thanks. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH] UML - forgot asm-um/cmpxchg.h

2007-05-03 Thread Jeff Dike
On Wed, May 02, 2007 at 11:09:19PM -0700, Andrew Morton wrote: > OK, I clumped all three patches into one as I think that's required for > git-bisect friendliness. OK - I separated the i386 and x86_64 bits to make it easy to drop the x86_64 part. Plus, I think it doesn't make any difference - the

Re: [PATCH] UML - forgot asm-um/cmpxchg.h

2007-05-02 Thread Andrew Morton
On Tue, 1 May 2007 15:36:46 -0400 Jeff Dike <[EMAIL PROTECTED]> wrote: > The i386 and x86_64 cmpxchg patches require an asm-um/cmpxchg.h for > the UML build. > > Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> > -- > include/asm-um/cmpxchg.h |6 ++ > 1 file changed, 6 insertions(+) > > Ind

Re: [patch] uml: fix cmpxchg warnings in -mm

2007-04-27 Thread Jeff Dike
On Fri, Apr 27, 2007 at 07:27:48PM +0200, Sam Ravnborg wrote: > Then atomic.h should include system.h and not rely on someone else doing it. > Yes - then system.h may be included twice but that's ok. I tried that - Andi didn't like it. My current thinking is to pull the cmpxchg stuff out of syste

Re: [patch] uml: fix cmpxchg warnings in -mm

2007-04-27 Thread Sam Ravnborg
On Fri, Apr 27, 2007 at 06:18:02PM +0200, Miklos Szeredi wrote: > > From: Miklos Szeredi <[EMAIL PROTECTED]> > > I get lot's of these on i386: > > In file included from include/asm/atomic.h:10, > from include/linux/file.h:9, > from mm/fadvise.c:12: > include/asm

Re: [PATCH] UML utrace support, step 1

2007-03-16 Thread Roland McGrath
> Did I send the right patch? The one I meant to send (appended below), > indeed builds and runs without utrace-regset.patch and > utrace-core.patch applied. It's utrace-1 in the following: That is not the same patch I tried before. This one does apply and build fine (after make defconfig ARCH=

Re: [PATCH] UML utrace support, step 1

2007-03-16 Thread Jeff Dike
On Wed, Mar 07, 2007 at 12:01:59AM -0800, Roland McGrath wrote: > > Below is a tracehook patch for UML which goes right after > > utrace-utrace-tracehook.patch. > > It does not. That patch has regset and ptrace stuff in it. It indeed > applies fine before or after utrace patches. But it doesn't

Re: [PATCH] UML utrace support, step 1

2007-03-07 Thread Roland McGrath
> On Thu, Feb 22, 2007 at 07:19:03PM -0800, Roland McGrath wrote: > > Your replacement patch still has utrace_regset stuff in it, so it doesn't > > compile without the later patches in the series. Try applying only > > utrace-tracehook.patch from the series, then get it to build and make your > >

Re: [PATCH] UML utrace support, step 1

2007-03-05 Thread Jeff Dike
On Thu, Feb 22, 2007 at 07:19:03PM -0800, Roland McGrath wrote: > Your replacement patch still has utrace_regset stuff in it, so it doesn't > compile without the later patches in the series. Try applying only > utrace-tracehook.patch from the series, then get it to build and make your > utrace-tra

Re: [PATCH] UML utrace support, step 1

2007-02-23 Thread Jeff Dike
On Thu, Feb 22, 2007 at 07:19:03PM -0800, Roland McGrath wrote: > Your replacement patch still has utrace_regset stuff in it, so it doesn't > compile without the later patches in the series. Try applying only > utrace-tracehook.patch from the series, then get it to build and make your > utrace-tra

Re: [PATCH] UML utrace support, step 1

2007-02-22 Thread Roland McGrath
> OK, I'll do it this way. Your replacement patch still has utrace_regset stuff in it, so it doesn't compile without the later patches in the series. Try applying only utrace-tracehook.patch from the series, then get it to build and make your utrace-tracehook-um.patch. Then apply only utrace-reg

Re: [PATCH] UML utrace support, step 1

2007-02-21 Thread Jeff Dike
On Wed, Feb 21, 2007 at 03:12:28AM -0800, Roland McGrath wrote: > The way I've organized my patch series is with the arch support split up > along with the separate infrastructure patches in the series. That is, > just asm/tracehook.h with no utrace_regset stuff in the first patch so that > the ke

Re: [PATCH] UML utrace support, step 1

2007-02-21 Thread Roland McGrath
> Below is the first step in your Fix-Your-Broken-Arch-HOWTO for UML. Great! Thanks for tackling this. > Do you want incremental patches as I go along, or replacement ones? The way I've organized my patch series is with the arch support split up along with the separate infrastructure patches in

Re: [PATCH] uml-i386: fix build breakage with CONFIG_HIGHMEM

2007-02-01 Thread Jeff Dike
On Thu, Feb 01, 2007 at 01:53:04PM +, Al Viro wrote: > missing helper used by arch/i386/mm/highmem.c, which is pulled > into build on that configuration. > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> ACK Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from t

Re: [PATCH] uml problems with linux/io.h

2006-12-08 Thread Jeff Dike
On Fri, Dec 08, 2006 at 09:45:30AM +, Al Viro wrote: > Remove useless includes of linux/io.h, don't even try to build iomap_copy > on uml (it doesn't have readb() et.al., so...) > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > --- > crypto/blkcipher.c |1 - > lib/Kconfig|5 +++

Re: [PATCH] uml:

2006-12-08 Thread Jeff Dike
On Fri, Dec 08, 2006 at 11:20:34AM +0100, Peter Zijlstra wrote: > > fixup the work on stack and exit scope trouble by placing the work_struct in > the uml_net_private data. > > Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Acked-by: Jeff Dike <[EMAIL PROTECTED]> -- Work email - jdike at li

Re: [PATCH] uml: fix net_kern workqueue abuse

2006-12-08 Thread Peter Zijlstra
Garh, it seems I forgot to finish the subject. On Fri, 2006-12-08 at 11:20 +0100, Peter Zijlstra wrote: > fixup the work on stack and exit scope trouble by placing the work_struct in > the uml_net_private data. > > Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> > --- > arch/um/drivers/net_ker

Re: [PATCH] uml: support a separate build tree; support USER_OBJS dependencies

2005-02-13 Thread Jeff Dike
[EMAIL PROTECTED] said: > Err... FWIW, aforementioned patch lacks e.g. vmlinux.lds.S. Yeah, I have that fixed locally. I just haven't pushed out the new stuff yet. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: [PATCH] uml: support a separate build tree; support USER_OBJS dependencies

2005-02-13 Thread Al Viro
On Sun, Feb 13, 2005 at 01:12:54PM -0500, Jeff Dike wrote: > [EMAIL PROTECTED] said: > > 1. To support a separate build tree for the um/i386 architecture the > > following changes have been done: > > Have a look at > > http://user-mode-linux.sourceforge.net/work/current/2.6/2.6.11-rc3-mm2

Re: [PATCH] uml: support a separate build tree; support USER_OBJS dependencies

2005-02-13 Thread Jeff Dike
[EMAIL PROTECTED] said: > 1. To support a separate build tree for the um/i386 architecture the > following changes have been done: Have a look at http://user-mode-linux.sourceforge.net/work/current/2.6/2.6.11-rc3-mm2/patches/cross-build That's Al Viro's take on the same problem, plus -

Re: [PATCH] UML - compile fixes for 2.6.11-rc3

2005-02-03 Thread Blaisorblade
On Thursday 03 February 2005 21:56, Jeff Dike wrote: > This fixes UML's sys_call_table to delete some entries for system calls > which have not yet made it into mainline from -mm. > > I also delete UML's __pud_alloc implementation since the memory.c one is > now enabled. Ok, thanks might you al