Re: [PATCH] ubifs: Fix error codes in ubifs_iget()

2016-01-03 Thread Richard Weinberger
Am 03.01.2016 um 14:54 schrieb Artem Bityutskiy: > On Sun, 2016-01-03 at 15:51 +0200, Artem Bityutskiy wrote: >> On Sat, 2016-01-02 at 23:11 +0100, Richard Weinberger wrote: >>> We cannot use positive error codes in ERR_PTR(). >>> IS_ERR() won't catch them. >> >> Right, but why there is a "err = -E

Re: [PATCH] ubifs: Fix error codes in ubifs_iget()

2016-01-03 Thread Artem Bityutskiy
On Sun, 2016-01-03 at 15:51 +0200, Artem Bityutskiy wrote: > On Sat, 2016-01-02 at 23:11 +0100, Richard Weinberger wrote: > > We cannot use positive error codes in ERR_PTR(). > > IS_ERR() won't catch them. > > Right, but why there is a "err = -EINVAL;" when at 'out_invalid'. Sorry Richard, I edit

Re: [PATCH] ubifs: Fix error codes in ubifs_iget()

2016-01-03 Thread Artem Bityutskiy
On Sat, 2016-01-02 at 23:11 +0100, Richard Weinberger wrote: > We cannot use positive error codes in ERR_PTR(). > IS_ERR() won't catch them. Right, but why there is a "err = -EINVAL;" when at 'out_invalid'. > Cc: sta...@vger.kernel.org > Signed-off-by: Richard Weinberger I do not see a bug, but