Re: [PATCH] tty: use __GFP_NOWARN for user-controlled kmalloc

2016-02-05 Thread One Thousand Gnomes
On Fri, 5 Feb 2016 08:06:12 +0100 Dmitry Vyukov wrote: > On Thu, Feb 4, 2016 at 11:11 PM, David Rientjes wrote: > > On Thu, 4 Feb 2016, Dmitry Vyukov wrote: > > > >> Size of kmalloc() in vc_do_resize() is controlled by user. > >> Too large kmalloc() size triggers WARNING message on console. >

Re: [PATCH] tty: use __GFP_NOWARN for user-controlled kmalloc

2016-02-05 Thread David Rientjes
On Fri, 5 Feb 2016, Dmitry Vyukov wrote: > On Thu, Feb 4, 2016 at 11:11 PM, David Rientjes wrote: > > On Thu, 4 Feb 2016, Dmitry Vyukov wrote: > > > >> Size of kmalloc() in vc_do_resize() is controlled by user. > >> Too large kmalloc() size triggers WARNING message on console. > >> > >> Use __GFP

Re: [PATCH] tty: use __GFP_NOWARN for user-controlled kmalloc

2016-02-04 Thread Dmitry Vyukov
On Thu, Feb 4, 2016 at 11:11 PM, David Rientjes wrote: > On Thu, 4 Feb 2016, Dmitry Vyukov wrote: > >> Size of kmalloc() in vc_do_resize() is controlled by user. >> Too large kmalloc() size triggers WARNING message on console. >> >> Use __GFP_NOWARN for this kmalloc() to not scare admins. >> > > H

Re: [PATCH] tty: use __GFP_NOWARN for user-controlled kmalloc

2016-02-04 Thread David Rientjes
On Thu, 4 Feb 2016, Dmitry Vyukov wrote: > Size of kmalloc() in vc_do_resize() is controlled by user. > Too large kmalloc() size triggers WARNING message on console. > > Use __GFP_NOWARN for this kmalloc() to not scare admins. > Hmm, this is hitting the WARN_ON_ONCE(!(gfp_mask & __GFP_NOWARN))

Re: [PATCH] tty: use __GFP_NOWARN for user-controlled kmalloc()

2016-02-04 Thread Peter Hurley
Hi Dmitry, Just a quick procedural note: tty patches need to be addressed to Greg. On 02/04/2016 07:55 AM, Dmitry Vyukov wrote: > Size of kmalloc() in vc_do_resize() is controlled by user. > Too large kmalloc() size triggers WARNING message on console. > > Use __GFP_NOWARN for this kmalloc() to