Re: [PATCH] tty: make sure a BUG is hit if tty_port will be destroyed before tty

2013-05-17 Thread Alexander Holler
Am 18.05.2013 00:51, schrieb Peter Hurley: On 05/17/2013 03:43 PM, Alexander Holler wrote: Am 17.05.2013 21:22, schrieb Alexander Holler: The case that the machine didn't die, but just the process, only happens when my proposed patch is applied, which prevents the memory corruption. In short

Re: [PATCH] tty: make sure a BUG is hit if tty_port will be destroyed before tty

2013-05-17 Thread Peter Hurley
On 05/17/2013 03:43 PM, Alexander Holler wrote: Am 17.05.2013 21:22, schrieb Alexander Holler: The case that the machine didn't die, but just the process, only happens when my proposed patch is applied, which prevents the memory corruption. In short, the proposed BUG_ON() prevents the memory

Re: [PATCH] tty: make sure a BUG is hit if tty_port will be destroyed before tty

2013-05-17 Thread Alexander Holler
Am 17.05.2013 21:22, schrieb Alexander Holler: > The case that the machine didn't die, but just the process, only happens > when my proposed patch is applied, which prevents the memory corruption. In short, the proposed BUG_ON() prevents the memory corruption because it is hit before something ba

Re: [PATCH] tty: make sure a BUG is hit if tty_port will be destroyed before tty

2013-05-17 Thread Alexander Holler
Am 17.05.2013 20:06, schrieb Peter Hurley: > On 05/17/2013 12:41 PM, Alexander Holler wrote: >> Am 17.05.2013 17:31, schrieb Greg Kroah-Hartman: >>> On Fri, May 17, 2013 at 09:12:08AM +0200, Alexander Holler wrote: tty depends on tty_port until tty_release() was called. Make sure a BUG wi

Re: [PATCH] tty: make sure a BUG is hit if tty_port will be destroyed before tty

2013-05-17 Thread Peter Hurley
On 05/17/2013 12:41 PM, Alexander Holler wrote: Am 17.05.2013 17:31, schrieb Greg Kroah-Hartman: On Fri, May 17, 2013 at 09:12:08AM +0200, Alexander Holler wrote: tty depends on tty_port until tty_release() was called. Make sure a BUG will be hit, if tty_port will be destroyed before tty. So

Re: [PATCH] tty: make sure a BUG is hit if tty_port will be destroyed before tty

2013-05-17 Thread Alexander Holler
Am 17.05.2013 17:31, schrieb Greg Kroah-Hartman: On Fri, May 17, 2013 at 09:12:08AM +0200, Alexander Holler wrote: tty depends on tty_port until tty_release() was called. Make sure a BUG will be hit, if tty_port will be destroyed before tty. So you want to ensure that we crash a machine? No,

Re: [PATCH] tty: make sure a BUG is hit if tty_port will be destroyed before tty

2013-05-17 Thread Greg Kroah-Hartman
On Fri, May 17, 2013 at 09:12:08AM +0200, Alexander Holler wrote: > tty depends on tty_port until tty_release() was called. Make sure a BUG > will be hit, if tty_port will be destroyed before tty. So you want to ensure that we crash a machine? No, please never add BUG() statements to the kernel,