Re: [PATCH] tty: Correct tty buffer flushing.

2012-12-04 Thread Ilya Zykov
On 04.12.2012 12:53, Alan Cox wrote: >> Main idea here - we never flash last (struct tty_buffer) in the >> active buffer. Only data for ldisc. (tty->buf.head->read = >> tty->buf.head->commit). At that moment driver can collect(write) data >> in buffer without conflict. > > This one I agree with (

Re: [PATCH] tty: Correct tty buffer flushing.

2012-12-04 Thread Alan Cox
> Main idea here - we never flash last (struct tty_buffer) in the > active buffer. Only data for ldisc. (tty->buf.head->read = > tty->buf.head->commit). At that moment driver can collect(write) data > in buffer without conflict. This one I agree with (sorry it took a while to get to, I wanted to

Re: [PATCH] tty: Correct tty buffer flushing.

2012-11-29 Thread Peter Hurley
On Thu, 2012-11-29 at 21:28 +, Alan Cox wrote: > > Sorry, In you reply not all patch. > > Main idea here - we never flash last (struct tty_buffer) in the > > active buffer. Only data for ldisc. (tty->buf.head->read = > > tty->buf.head->commit). At that moment driver can collect(write) data > >

Re: [PATCH] tty: Correct tty buffer flushing.

2012-11-29 Thread Alan Cox
> Sorry, In you reply not all patch. > Main idea here - we never flash last (struct tty_buffer) in the > active buffer. Only data for ldisc. (tty->buf.head->read = > tty->buf.head->commit). At that moment driver can collect(write) data > in buffer without conflict. Ah.. now I understand. Yes that

Re: [PATCH] tty: Correct tty buffer flushing.

2012-11-29 Thread Ilya Zykov
On 29.11.2012 17:54, Alan Cox wrote: >> diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c >> index 6c9b7cd..4f02f9c 100644 >> --- a/drivers/tty/tty_buffer.c >> +++ b/drivers/tty/tty_buffer.c >> @@ -114,11 +114,14 @@ static void __tty_buffer_flush(struct tty_struct *tty) >> { >>

Re: [PATCH] tty: Correct tty buffer flushing.

2012-11-29 Thread Ilya Zykov
On 29.11.2012 17:54, Alan Cox wrote: >> diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c >> index 6c9b7cd..4f02f9c 100644 >> --- a/drivers/tty/tty_buffer.c >> +++ b/drivers/tty/tty_buffer.c >> @@ -114,11 +114,14 @@ static void __tty_buffer_flush(struct tty_struct *tty) >> { >>

Re: [PATCH] tty: Correct tty buffer flushing.

2012-11-29 Thread Ilya Zykov
On 29.11.2012 17:54, Alan Cox wrote: >> diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c >> index 6c9b7cd..4f02f9c 100644 >> --- a/drivers/tty/tty_buffer.c >> +++ b/drivers/tty/tty_buffer.c >> @@ -114,11 +114,14 @@ static void __tty_buffer_flush(struct tty_struct *tty) >> { >>

Re: [PATCH] tty: Correct tty buffer flushing.

2012-11-29 Thread Alan Cox
> diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c > index 6c9b7cd..4f02f9c 100644 > --- a/drivers/tty/tty_buffer.c > +++ b/drivers/tty/tty_buffer.c > @@ -114,11 +114,14 @@ static void __tty_buffer_flush(struct tty_struct *tty) > { > struct tty_buffer *thead; > > - whil