Re: [PATCH] tracing: Fix double free of event_trigger_data

2018-07-25 Thread Masami Hiramatsu
On Wed, 25 Jul 2018 15:53:21 -0400 Steven Rostedt wrote: > On Wed, 25 Jul 2018 15:29:04 -0400 > Steven Rostedt wrote: > > > Nope, this doesn't work. It's a little more complex than the other one. > > I'll just leave it, and fix the reg code for 4.19. > > I take this back. Looks like it just ne

Re: [PATCH] tracing: Fix double free of event_trigger_data

2018-07-25 Thread Steven Rostedt
On Wed, 25 Jul 2018 15:29:04 -0400 Steven Rostedt wrote: > Nope, this doesn't work. It's a little more complex than the other one. > I'll just leave it, and fix the reg code for 4.19. I take this back. Looks like it just needs to be handled slightly differently. Thoughts? -- Steve diff --git a

Re: [PATCH] tracing: Fix double free of event_trigger_data

2018-07-25 Thread Steven Rostedt
On Wed, 25 Jul 2018 12:40:08 -0400 Steven Rostedt wrote: > Hmm, looks to me that event_enable_trigger_func() suffers the same > issue. Perhaps we should add this patch too: > > -- Steve > > diff --git a/kernel/trace/trace_events_trigger.c > b/kernel/trace/trace_events_trigger.c > index d18ec0e

Re: [PATCH] tracing: Fix double free of event_trigger_data

2018-07-25 Thread Steven Rostedt
On Thu, 26 Jul 2018 00:43:49 +0900 Masami Hiramatsu wrote: > On Wed, 25 Jul 2018 08:57:40 -0400 > Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > > Running the following: > > > > # cd /sys/kernel/debug/tracing > > # echo 50 > buffer_size_kb > > [ Or some other number

Re: [PATCH] tracing: Fix double free of event_trigger_data

2018-07-25 Thread Masami Hiramatsu
On Wed, 25 Jul 2018 08:57:40 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Running the following: > > # cd /sys/kernel/debug/tracing > # echo 50 > buffer_size_kb > [ Or some other number that takes up most of memory ] > # echo snapshot > events/sched/sched_switch/tri