Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer address

2015-09-29 Thread Jarkko Sakkinen
Hi Peter, On Mon, Sep 28, 2015 at 11:12:59PM -0700, Peter Huewe wrote: > Hi, > is this for stable as well? > Since when? > > I'll take care of all the patches next week when coming back to germany. This is definitely also for the stable. > Peter /Jarkko -- To unsubscribe from this list: send t

Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer address

2015-09-28 Thread Peter Huewe
Hi, is this for stable as well? Since when? I'll take care of all the patches next week when coming back to germany. Peter -- Sent from my mobile -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info a

Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer address

2015-09-15 Thread Jarkko Sakkinen
On Tue, Sep 15, 2015 at 10:30:39AM -0600, Jason Gunthorpe wrote: > On Tue, Sep 15, 2015 at 01:09:56PM +0300, Jarkko Sakkinen wrote: > > However, for MMIO address the hardware might abort the entire request > > when trying to do a 64-bit read, which causes the CPU to fill the result > > with 1's. >

Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer address

2015-09-15 Thread Jason Gunthorpe
On Tue, Sep 15, 2015 at 01:09:56PM +0300, Jarkko Sakkinen wrote: > However, for MMIO address the hardware might abort the entire request > when trying to do a 64-bit read, which causes the CPU to fill the result > with 1's. Okay, yes, for iomem you can't rely on packed. packed actually can mess u

Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer address

2015-09-15 Thread Jarkko Sakkinen
On Mon, Sep 14, 2015 at 11:35:23AM -0600, Jason Gunthorpe wrote: > On Mon, Sep 14, 2015 at 08:15:23PM +0300, Jarkko Sakkinen wrote: > > The command buffer address is necessarily not naturally aligned. > > The hardware drops the entire read on some platforms and fills the > > address with 1's. This

Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer address

2015-09-14 Thread Jason Gunthorpe
On Mon, Sep 14, 2015 at 08:15:23PM +0300, Jarkko Sakkinen wrote: > The command buffer address is necessarily not naturally aligned. > The hardware drops the entire read on some platforms and fills the > address with 1's. This patch fixes the issue by splitting the read > into two 32 bit reads. Is