Re: [PATCH] time: Make NTP optionnal

2017-11-20 Thread Alan Cox
On Mon, 20 Nov 2017 17:29:53 +0100 Romain Perier wrote: > So even if the correspondong syscall are disabled and the > corresponding clocks too, you should return an -ENOSYS from the > do_adjtimex helper, in case that another component tries to use it in > the kernel, right ? Probably - but you n

Re: [PATCH] time: Make NTP optionnal

2017-11-20 Thread Romain Perier
So even if the correspondong syscall are disabled and the corresponding clocks too, you should return an -ENOSYS from the do_adjtimex helper, in case that another component tries to use it in the kernel, right ? Regards, Romain 2017-11-20 17:08 GMT+01:00 Alan Cox : > On Mon, 20 Nov 2017 16:22:06

Re: [PATCH] time: Make NTP optionnal

2017-11-20 Thread Alan Cox
On Mon, 20 Nov 2017 16:22:06 +0100 peter enderborg wrote: > On 11/20/2017 04:00 PM, Romain Perier wrote: > > Hi, > > > > 2017-11-20 15:10 GMT+01:00 peter enderborg : > >> I think it should return a error code at least. > > In which case ? The idea was to don't change the behaviour of these >

Re: [PATCH] time: Make NTP optionnal

2017-11-20 Thread peter enderborg
On 11/20/2017 04:00 PM, Romain Perier wrote: > Hi, > > 2017-11-20 15:10 GMT+01:00 peter enderborg : >> I think it should return a error code at least. > In which case ? The idea was to don't change the behaviour of these > functions (from the "API" point of view) and to avoid regressions in > the

Re: [PATCH] time: Make NTP optionnal

2017-11-20 Thread Romain Perier
Hi, 2017-11-20 15:10 GMT+01:00 peter enderborg : > I think it should return a error code at least. In which case ? The idea was to don't change the behaviour of these functions (from the "API" point of view) and to avoid regressions in the kernel components that depend on these NTP feature. (so b

Re: [PATCH] time: Make NTP optionnal

2017-11-20 Thread peter enderborg
I think it should return a error code at least. On 11/02/2017 07:29 PM, Romain Perier wrote: > On embedded systems with limited space, synchronizing system clock via > NTP might be not needed. > > This commit introduces a new Kconfig entry. When disabled, it compiles > out the adjtimex and clock_a

Re: [PATCH] time: Make NTP optionnal

2017-11-20 Thread Romain Perier
Hi, No feedback regarding this patch ? Thanks, Romain 2017-11-02 19:29 GMT+01:00 Romain Perier : > On embedded systems with limited space, synchronizing system clock via > NTP might be not needed. > > This commit introduces a new Kconfig entry. When disabled, it compiles > out the adjtimex and c