Re: [PATCH] tick/nohz: Reduce the critical region for jiffies_seq

2020-11-16 Thread Thomas Gleixner
On Mon, Nov 16 2020 at 21:24, Yunfeng Ye wrote: > On 2020/11/16 19:29, Thomas Gleixner wrote: >> There are quite some other inefficiencies in that code and the seqcount >> held time can be reduced way further. Let me stare at it. >> > I think the write seqcount only protecting the last_jiffies_upd

Re: [PATCH] tick/nohz: Reduce the critical region for jiffies_seq

2020-11-16 Thread Yunfeng Ye
On 2020/11/16 19:29, Thomas Gleixner wrote: > On Mon, Nov 16 2020 at 14:07, Yunfeng Ye wrote: >> On 2020/11/16 3:43, Thomas Gleixner wrote: and the conflict between jiffies_lock and jiffies_seq increases, especially in multi-core scenarios. >>> >>> This does not make sense. The sequenc

Re: [PATCH] tick/nohz: Reduce the critical region for jiffies_seq

2020-11-16 Thread Thomas Gleixner
On Mon, Nov 16 2020 at 14:07, Yunfeng Ye wrote: > On 2020/11/16 3:43, Thomas Gleixner wrote: >>> and the conflict between jiffies_lock and jiffies_seq increases, >>> especially in multi-core scenarios. >> >> This does not make sense. The sequence counter is updated when holding >> the lock, so the

Re: [PATCH] tick/nohz: Reduce the critical region for jiffies_seq

2020-11-15 Thread Yunfeng Ye
On 2020/11/16 3:43, Thomas Gleixner wrote: > On Wed, Nov 11 2020 at 17:11, Yunfeng Ye wrote: >> When nohz or nohz_full is configured, the concurrency calls of >> tick_do_update_jiffies64 increases, > > Why? > When nohz=off, tick_do_update_jiffies64() is called by tick_sched_do_timer() on the t

Re: [PATCH] tick/nohz: Reduce the critical region for jiffies_seq

2020-11-15 Thread Thomas Gleixner
On Wed, Nov 11 2020 at 17:11, Yunfeng Ye wrote: > When nohz or nohz_full is configured, the concurrency calls of > tick_do_update_jiffies64 increases, Why? > and the conflict between jiffies_lock and jiffies_seq increases, > especially in multi-core scenarios. This does not make sense. The seque