Re: [PATCH] sym53c8xx timer and smp fixes

2001-06-04 Thread Gérard Roudier
On Thu, 31 May 2001, Tim Hockin wrote: > All, > > Attached is a patch for sym53c8xx.c to handle the error timer better, and > be more proper for SMP. The changes are very simple, and have been beaten > on by us. Please let me know if there are any problems accepting this > patch for general

Re: [PATCH] sym53c8xx timer and smp fixes

2001-06-01 Thread Gérard Roudier
On Fri, 1 Jun 2001, Jeff Garzik wrote: > Tim Hockin wrote: > > spinlock_t sym53c8xx_lock = SPIN_LOCK_UNLOCKED; > > +spinlock_t sym53c8xx_host_lock = SPIN_LOCK_UNLOCKED; > > #defineNCR_LOCK_DRIVER(flags) spin_lock_irqsave(&sym53c8xx_lock, >flags) > > #defineNCR_UNLOCK_DRI

Re: [PATCH] sym53c8xx timer and smp fixes

2001-06-01 Thread Studierende der Universitaet des Saarlandes
Jeff wrote: > > so, this driver is mixed spinlocks and save/restore_flags? Any > chance this can be converted to all spinlocks? > It's spinlock for 2.2 and 2.4 kernels, and save_flags for 2.0. Tim, did you cc Gerard Roudier? He mainains the sym53c8xx driver. All mail archives strip the cc list :

Re: [PATCH] sym53c8xx timer and smp fixes

2001-06-01 Thread Jeff Garzik
Tim Hockin wrote: > spinlock_t sym53c8xx_lock = SPIN_LOCK_UNLOCKED; > +spinlock_t sym53c8xx_host_lock = SPIN_LOCK_UNLOCKED; > #defineNCR_LOCK_DRIVER(flags) spin_lock_irqsave(&sym53c8xx_lock, flags) > #defineNCR_UNLOCK_DRIVER(flags) >spin_unlock_irqrestore(&sym53c8xx_lock,