Re: [PATCH] structleak: disable BYREF_ALL in combination with KASAN_STACK

2019-06-25 Thread Ard Biesheuvel
On Sat, 22 Jun 2019 at 22:26, Kees Cook wrote: > > On Fri, Jun 21, 2019 at 03:50:02PM +0200, Ard Biesheuvel wrote: > > On Fri, 21 Jun 2019 at 15:44, Arnd Bergmann wrote: > > > One pattern I have seen here is temporary variables from macros or > > > inline functions whose lifetime now extends over

Re: [PATCH] structleak: disable BYREF_ALL in combination with KASAN_STACK

2019-06-22 Thread Kees Cook
On Fri, Jun 21, 2019 at 03:50:02PM +0200, Ard Biesheuvel wrote: > On Fri, 21 Jun 2019 at 15:44, Arnd Bergmann wrote: > > One pattern I have seen here is temporary variables from macros or > > inline functions whose lifetime now extends over the entire function > > rather than just the basic block

Re: [PATCH] structleak: disable BYREF_ALL in combination with KASAN_STACK

2019-06-21 Thread Ard Biesheuvel
On Fri, 21 Jun 2019 at 15:44, Arnd Bergmann wrote: > > On Fri, Jun 21, 2019 at 3:32 PM Ard Biesheuvel > wrote: > > On Fri, 21 Jun 2019 at 11:44, Arnd Bergmann wrote: > > > On Thu, Jun 20, 2019 at 7:36 PM Kees Cook wrote: > > > > On Tue, Jun 18, 2019 at 11:47:13AM +0200, Arnd Bergmann wrote: > >

Re: [PATCH] structleak: disable BYREF_ALL in combination with KASAN_STACK

2019-06-21 Thread Arnd Bergmann
On Fri, Jun 21, 2019 at 3:32 PM Ard Biesheuvel wrote: > On Fri, 21 Jun 2019 at 11:44, Arnd Bergmann wrote: > > On Thu, Jun 20, 2019 at 7:36 PM Kees Cook wrote: > > > On Tue, Jun 18, 2019 at 11:47:13AM +0200, Arnd Bergmann wrote: > > > > The combination of KASAN_STACK and GCC_PLUGIN_STRUCTLEAK_BY

Re: [PATCH] structleak: disable BYREF_ALL in combination with KASAN_STACK

2019-06-21 Thread Ard Biesheuvel
On Fri, 21 Jun 2019 at 11:44, Arnd Bergmann wrote: > > On Thu, Jun 20, 2019 at 7:36 PM Kees Cook wrote: > > > > On Tue, Jun 18, 2019 at 11:47:13AM +0200, Arnd Bergmann wrote: > > > The combination of KASAN_STACK and GCC_PLUGIN_STRUCTLEAK_BYREF_ALL > > > leads to much larger kernel stack usage, as

Re: [PATCH] structleak: disable BYREF_ALL in combination with KASAN_STACK

2019-06-21 Thread Arnd Bergmann
On Thu, Jun 20, 2019 at 7:36 PM Kees Cook wrote: > > On Tue, Jun 18, 2019 at 11:47:13AM +0200, Arnd Bergmann wrote: > > The combination of KASAN_STACK and GCC_PLUGIN_STRUCTLEAK_BYREF_ALL > > leads to much larger kernel stack usage, as seen from the warnings > > about functions that now exceed the

Re: [PATCH] structleak: disable BYREF_ALL in combination with KASAN_STACK

2019-06-20 Thread Kees Cook
On Tue, Jun 18, 2019 at 11:47:13AM +0200, Arnd Bergmann wrote: > The combination of KASAN_STACK and GCC_PLUGIN_STRUCTLEAK_BYREF_ALL > leads to much larger kernel stack usage, as seen from the warnings > about functions that now exceed the 2048 byte limit: Is the preference that this go into v5.2 (