Re: [PATCH] staging: rtl8723bs: Use shared header constants

2020-05-28 Thread Dan Carpenter
On Wed, May 27, 2020 at 09:33:03PM +0100, Pascal Terjan wrote: > On Wed, 27 May 2020 at 20:48, Dan Carpenter wrote: > > > /* eth_type = (psnap_type[0] << 8) | psnap_type[1]; */ > > > - if ((!memcmp(psnap, rtw_rfc1042_header, SNAP_SIZE) && > > > - (memcmp(psnap_type, SNAP_ETH_

Re: [PATCH] staging: rtl8723bs: Use shared header constants

2020-05-27 Thread Pascal Terjan
On Wed, 27 May 2020 at 20:48, Dan Carpenter wrote: > > On Sat, May 23, 2020 at 10:29:19PM +0100, Pascal Terjan wrote: > > This is one of the 9 drivers redefining rfc1042_header. > > > > This is how the patch looks like in my email client: > > https://marc.info/?l=linux-driver-devel&m=1590269738218

Re: [PATCH] staging: rtl8723bs: Use shared header constants

2020-05-27 Thread Dan Carpenter
On Sat, May 23, 2020 at 10:29:19PM +0100, Pascal Terjan wrote: > This is one of the 9 drivers redefining rfc1042_header. > This is how the patch looks like in my email client: https://marc.info/?l=linux-driver-devel&m=159026973821890&w=2 Do you see how the subject is far away from the body of t

Re: [PATCH] staging: rtl8723bs: Use shared header constants

2020-05-27 Thread Greg Kroah-Hartman
On Sat, May 23, 2020 at 10:29:19PM +0100, Pascal Terjan wrote: > This is one of the 9 drivers redefining rfc1042_header. I do not understand what this changelog is trying to say. Can you fix this up to be more explicit and detained and resend? thanks, greg k-h