Re: [PATCH] staging: rtl8723bs: Change foo* bar to foo *bar

2017-09-09 Thread Joe Perches
On Sat, 2017-09-09 at 18:50 +0200, Greg KH wrote: > On Sat, Sep 09, 2017 at 10:09:37PM +0530, Harsha Sharma wrote: > > This coding style (foo *bar) is more common for the kernel code. > > You also did something else in this patch that you did not mention here, > which is not ok :( what is that?

Re: [PATCH] staging: rtl8723bs: Change foo* bar to foo *bar

2017-09-09 Thread Greg KH
On Sat, Sep 09, 2017 at 10:09:37PM +0530, Harsha Sharma wrote: > This coding style (foo *bar) is more common for the kernel code. You also did something else in this patch that you did not mention here, which is not ok :( Remember, only one type of thing per patch. thanks, greg k-h