Re: [PATCH] staging: rtl8192u: Remove an unnecessary NULL check

2019-05-22 Thread Nathan Chancellor
On Wed, May 22, 2019 at 10:04:18AM +0300, Dan Carpenter wrote: > On Tue, May 21, 2019 at 10:42:21AM -0700, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2663:47: warning: > > address of array 'param->u.wpa_ie.data' will always evaluate to

Re: [PATCH] staging: rtl8192u: Remove an unnecessary NULL check

2019-05-22 Thread Dan Carpenter
On Tue, May 21, 2019 at 03:57:46PM -0700, Nick Desaulniers wrote: > > > - if (param->u.wpa_ie.len > MAX_WPA_IE_LEN || > > > - (param->u.wpa_ie.len && !param->u.wpa_ie.data)) > > > > Right so, the types in this expression: > > > > param: struct ieee_param* > > param->u: *anonymous un

Re: [PATCH] staging: rtl8192u: Remove an unnecessary NULL check

2019-05-22 Thread Dan Carpenter
On Tue, May 21, 2019 at 10:42:21AM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2663:47: warning: > address of array 'param->u.wpa_ie.data' will always evaluate to 'true' > [-Wpointer-bool-conversion] > (param->u.wpa_ie.len &

Re: [PATCH] staging: rtl8192u: Remove an unnecessary NULL check

2019-05-21 Thread Nick Desaulniers
+ Richard for real this time. On Tue, May 21, 2019 at 3:53 PM Nick Desaulniers wrote: > > On Tue, May 21, 2019 at 10:42 AM Nathan Chancellor > wrote: > > > > Clang warns: > > > > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2663:47: warning: > > address of array 'param->u.wpa_ie.data'

Re: [PATCH] staging: rtl8192u: Remove an unnecessary NULL check

2019-05-21 Thread Nick Desaulniers
On Tue, May 21, 2019 at 10:42 AM Nathan Chancellor wrote: > > Clang warns: > > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2663:47: warning: > address of array 'param->u.wpa_ie.data' will always evaluate to 'true' > [-Wpointer-bool-conversion] > (param->u.wpa_ie.len && !para