Re: [PATCH] staging: panel: Remove magic numbers in LCD commands

2014-12-06 Thread Mariusz Gorski
On Sat, Dec 06, 2014 at 01:46:52PM +0530, Sudip Mukherjee wrote: > On Fri, Dec 05, 2014 at 10:10:43PM +0100, Mariusz Gorski wrote: > > Get rid of magic numbers in LCD commands and replace them with defined > > values, so that it's more obvious that the commands are doing. > > > it is not applying

Re: [PATCH] staging: panel: Remove magic numbers in LCD commands

2014-12-06 Thread Sudip Mukherjee
On Fri, Dec 05, 2014 at 10:10:43PM +0100, Mariusz Gorski wrote: > Get rid of magic numbers in LCD commands and replace them with defined > values, so that it's more obvious that the commands are doing. > it is not applying to next-20141205. is it based on staging-testing ? thanks sudip > Signed-

Re: [PATCH] staging: panel: Remove magic numbers in LCD commands

2014-12-05 Thread Willy Tarreau
On Fri, Dec 05, 2014 at 10:10:43PM +0100, Mariusz Gorski wrote: > Get rid of magic numbers in LCD commands and replace them with defined > values, so that it's more obvious that the commands are doing. > > Signed-off-by: Mariusz Gorski I didn't remember I wrote something that awful! Obvious ack.