Re: [PATCH] spi: spi-sun6i: implement DMA-based transfer mode

2020-10-21 Thread Maxime Ripard
Hi, On Mon, Oct 19, 2020 at 04:17:18PM +0300, Alexander Kochetkov wrote: > >> +static int sun6i_spi_prepare_dma(struct sun6i_spi *sspi, > >> + struct spi_transfer *tfr) > >> +{ > >> + struct dma_async_tx_descriptor *rxdesc, *txdesc; > >> + struct spi_master *master = ss

Re: [PATCH] spi: spi-sun6i: implement DMA-based transfer mode

2020-10-21 Thread Maxime Ripard
On Tue, Oct 20, 2020 at 11:52:34AM +0800, Chen-Yu Tsai wrote: > On Tue, Oct 20, 2020 at 1:43 AM Alexander Kochetkov > wrote: > > > > > > > > > 19 окт. 2020 г., в 11:21, Maxime Ripard написал(а): > > > > > > Hi! > > > > > > On Thu, Oct 15, 2020 at 06:47:40PM +0300, Alexander Kochetkov wrote: > >

Re: [PATCH] spi: spi-sun6i: implement DMA-based transfer mode

2020-10-19 Thread Chen-Yu Tsai
On Tue, Oct 20, 2020 at 1:43 AM Alexander Kochetkov wrote: > > > > > 19 окт. 2020 г., в 11:21, Maxime Ripard написал(а): > > > > Hi! > > > > On Thu, Oct 15, 2020 at 06:47:40PM +0300, Alexander Kochetkov wrote: > >> DMA-based transfer will be enabled if data length is larger than FIFO size > >> (6

Re: [PATCH] spi: spi-sun6i: implement DMA-based transfer mode

2020-10-19 Thread Alexander Kochetkov
> 19 окт. 2020 г., в 11:21, Maxime Ripard написал(а): > > Hi! > > On Thu, Oct 15, 2020 at 06:47:40PM +0300, Alexander Kochetkov wrote: >> DMA-based transfer will be enabled if data length is larger than FIFO size >> (64 bytes for A64). This greatly reduce number of interrupts for >> transferr

Re: [PATCH] spi: spi-sun6i: implement DMA-based transfer mode

2020-10-19 Thread Alexander Kochetkov
Hi, Maxime! Thanks for reviewing patches! >> >> +static int sun6i_spi_prepare_dma(struct sun6i_spi *sspi, >> + struct spi_transfer *tfr) >> +{ >> +struct dma_async_tx_descriptor *rxdesc, *txdesc; >> +struct spi_master *master = sspi->master; >> + >> +rxdes

Re: [PATCH] spi: spi-sun6i: implement DMA-based transfer mode

2020-10-19 Thread Maxime Ripard
Hi! On Thu, Oct 15, 2020 at 06:47:40PM +0300, Alexander Kochetkov wrote: > DMA-based transfer will be enabled if data length is larger than FIFO size > (64 bytes for A64). This greatly reduce number of interrupts for > transferring data. > > For smaller data size PIO mode will be used. In PIO mod