Re: [PATCH] sparse doesn't support indirect_branch attribute

2018-03-01 Thread Masahiro Yamada
2018-03-01 19:06 GMT+09:00 Luc Van Oostenryck : > On Wed, Feb 28, 2018 at 10:30:58AM +0900, Masahiro Yamada wrote: >> 2018-02-28 7:36 GMT+09:00 Luc Van Oostenryck : >> > >> > To compensate this, I sent a patch to use '-Wno-unknown-attribute' for >> > kernel >> > builds. Masahiro Yamada has alread

Re: [PATCH] sparse doesn't support indirect_branch attribute

2018-03-01 Thread Luc Van Oostenryck
On Wed, Feb 28, 2018 at 10:30:58AM +0900, Masahiro Yamada wrote: > 2018-02-28 7:36 GMT+09:00 Luc Van Oostenryck : > > > > To compensate this, I sent a patch to use '-Wno-unknown-attribute' for > > kernel > > builds. Masahiro Yamada has already taken it to the linux-kbuild tree. > > I'm not sure i

Re: [PATCH] sparse doesn't support indirect_branch attribute

2018-02-27 Thread Masahiro Yamada
2018-02-28 7:36 GMT+09:00 Luc Van Oostenryck : > On Tue, Feb 27, 2018 at 02:12:28PM -0800, Linus Torvalds wrote: >> On Tue, Feb 27, 2018 at 12:18 PM, Randy Dunlap wrote: >> > >> > I don't mind the patch, but I did send a patch for this attribute on Feb. >> > 13, 2018, >> > to the sparse mailing l

Re: [PATCH] sparse doesn't support indirect_branch attribute

2018-02-27 Thread Luc Van Oostenryck
On Tue, Feb 27, 2018 at 02:12:28PM -0800, Linus Torvalds wrote: > On Tue, Feb 27, 2018 at 12:18 PM, Randy Dunlap wrote: > > > > I don't mind the patch, but I did send a patch for this attribute on Feb. > > 13, 2018, > > to the sparse mailing list. > > I think the sparse plan is to just stop warn

Re: [PATCH] sparse doesn't support indirect_branch attribute

2018-02-27 Thread Linus Torvalds
On Tue, Feb 27, 2018 at 2:30 PM, Randy Dunlap wrote: > > There is also a kernel kbuild patch from Luc that Masahiro has also merged > that > does -Wno-unknown-attributes (or however that is spelled). That's probably a better interim workaround. Linus

Re: [PATCH] sparse doesn't support indirect_branch attribute

2018-02-27 Thread Randy Dunlap
On 02/27/2018 02:12 PM, Linus Torvalds wrote: > On Tue, Feb 27, 2018 at 12:18 PM, Randy Dunlap wrote: >> >> I don't mind the patch, but I did send a patch for this attribute on Feb. >> 13, 2018, >> to the sparse mailing list. > > I think the sparse plan is to just stop warning about unknown > at

Re: [PATCH] sparse doesn't support indirect_branch attribute

2018-02-27 Thread Linus Torvalds
On Tue, Feb 27, 2018 at 12:18 PM, Randy Dunlap wrote: > > I don't mind the patch, but I did send a patch for this attribute on Feb. 13, > 2018, > to the sparse mailing list. I think the sparse plan is to just stop warning about unknown attributes, because it doesn't really help users (at most it

Re: [PATCH] sparse doesn't support indirect_branch attribute

2018-02-27 Thread Randy Dunlap
On 02/27/2018 11:48 AM, Matthew Wilcox wrote: > > Don't use __attribute__((indirect_branch)) if we're compiling with > sparse. > > Signed-off-by: Matthew Wilcox > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > index e2c7f4369eff..b6be4cc25e9d 100644 > --- a/include