Re: [PATCH] serial: samsung: add support for manual RTS setting

2013-09-18 Thread Tomasz Figa
On Tuesday 17 of September 2013 20:08:33 José Miguel Gonçalves wrote: > On 17-09-2013 16:21, Tomasz Figa wrote: > > I had the following scenario in mind: > > 1) enable CRTSCTS, > > 2) set RTS status using the IOCTL, > > 3) disable CRTSCTS, > > 4) do something, > > 5) enable CRTSCTS again. > > > >

Re: [PATCH] serial: samsung: add support for manual RTS setting

2013-09-17 Thread José Miguel Gonçalves
On 17-09-2013 16:21, Tomasz Figa wrote: I had the following scenario in mind: 1) enable CRTSCTS, 2) set RTS status using the IOCTL, 3) disable CRTSCTS, 4) do something, 5) enable CRTSCTS again. I would expect that the value set in point 2 would be still valid after point 5, while it will be rese

Re: [PATCH] serial: samsung: add support for manual RTS setting

2013-09-17 Thread Tomasz Figa
[Ccing Greg and Sylwester] On Tuesday 17 of September 2013 14:03:35 José Miguel Gonçalves wrote: > Hi Tomasz, > > On 17-09-2013 11:18, Tomasz Figa wrote: > > Hi José, > > > > Please see my comments below. > > > > On Wednesday 11 of September 2013 11:08:27 José Miguel Gonçalves wrote: > >> The S

Re: [PATCH] serial: samsung: add support for manual RTS setting

2013-09-17 Thread José Miguel Gonçalves
Hi Tomasz, On 17-09-2013 11:18, Tomasz Figa wrote: Hi José, Please see my comments below. On Wednesday 11 of September 2013 11:08:27 José Miguel Gonçalves wrote: The Samsung serial driver currently does not support setting the RTS pin with an ioctl(TIOCMSET) call. This patch adds this support

Re: [PATCH] serial: samsung: add support for manual RTS setting

2013-09-17 Thread Tomasz Figa
Hi José, Please see my comments below. On Wednesday 11 of September 2013 11:08:27 José Miguel Gonçalves wrote: > The Samsung serial driver currently does not support setting the > RTS pin with an ioctl(TIOCMSET) call. This patch adds this support. > > Signed-off-by: José Miguel Gonçalves > ---