Re: [PATCH] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c

2014-09-08 Thread Behan Webster
On 09/08/14 08:43, Mimi Zohar wrote: Behan, thank you for the explanation. No worries. I should have explained better. My apologies. The same snippet of code used here, and elsewhere in the kernel, is taken from the crypto subsystem. Once it is resolved in the crypto subsystem, the same solut

Re: [PATCH] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c

2014-09-08 Thread Mimi Zohar
On Mon, 2014-09-08 at 07:25 -0500, Behan Webster wrote: > On 09/08/14 04:15, Dmitry Kasatkin wrote: > > On 07/09/14 05:06, Behan Webster wrote: > >> On 09/06/14 03:11, Thomas Gleixner wrote: > >>> On Fri, 5 Sep 2014, Behan Webster wrote: > On 09/05/14 17:18, Thomas Gleixner wrote: > >> Si

Re: [PATCH] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c

2014-09-08 Thread Behan Webster
On 09/08/14 04:15, Dmitry Kasatkin wrote: On 07/09/14 05:06, Behan Webster wrote: On 09/06/14 03:11, Thomas Gleixner wrote: On Fri, 5 Sep 2014, Behan Webster wrote: On 09/05/14 17:18, Thomas Gleixner wrote: Signed-off-by: Behan Webster Signed-off-by: Mark Charlebois Signed-off-by: Jan-Simon

Re: [PATCH] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c

2014-09-08 Thread Dmitry Kasatkin
On 07/09/14 05:06, Behan Webster wrote: > On 09/06/14 03:11, Thomas Gleixner wrote: >> On Fri, 5 Sep 2014, Behan Webster wrote: >>> On 09/05/14 17:18, Thomas Gleixner wrote: > Signed-off-by: Behan Webster > Signed-off-by: Mark Charlebois > Signed-off-by: Jan-Simon Möller This SO

Re: [PATCH] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c

2014-09-06 Thread Behan Webster
On 09/06/14 03:11, Thomas Gleixner wrote: On Fri, 5 Sep 2014, Behan Webster wrote: On 09/05/14 17:18, Thomas Gleixner wrote: Signed-off-by: Behan Webster Signed-off-by: Mark Charlebois Signed-off-by: Jan-Simon Möller This SOB chain is completely ass backwards. See Documentation/... "The Si

Re: [PATCH] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c

2014-09-06 Thread Thomas Gleixner
On Fri, 5 Sep 2014, Behan Webster wrote: > On 09/05/14 17:18, Thomas Gleixner wrote: > > > Signed-off-by: Behan Webster > > > Signed-off-by: Mark Charlebois > > > Signed-off-by: Jan-Simon Möller > > This SOB chain is completely ass backwards. See Documentation/... > "The Signed-off-by: tag indic

Re: [PATCH] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c

2014-09-05 Thread Behan Webster
On 09/05/14 17:18, Thomas Gleixner wrote: On Fri, 5 Sep 2014, beh...@converseincode.com wrote: From: Behan Webster Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99 compliant equivalent. This patch allocates the appropriate amount of memory using an char array. The new

Re: [PATCH] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c

2014-09-05 Thread Thomas Gleixner
On Fri, 5 Sep 2014, beh...@converseincode.com wrote: > From: Behan Webster > > Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99 > compliant equivalent. This patch allocates the appropriate amount of memory > using an char array. > > The new code can be compiled with both