Re: [PATCH] scripts/faddr2line: show the code context

2018-06-03 Thread Du, Changbin
On Tue, May 29, 2018 at 06:03:32PM +0200, Peter Zijlstra wrote: > On Mon, Mar 19, 2018 at 03:23:25PM +0800, changbin...@intel.com wrote: > > From: Changbin Du > > > > Inspired by gdb command 'list', show the code context of target lines. > > Here is a example: > > > > $ scripts/faddr2line vmlinu

Re: [PATCH] scripts/faddr2line: show the code context

2018-06-03 Thread Du, Changbin
On Wed, May 30, 2018 at 08:01:48AM +1000, NeilBrown wrote: > On Tue, May 29 2018, Peter Zijlstra wrote: > > > On Tue, May 29, 2018 at 12:07:10PM -0500, Josh Poimboeuf wrote: > >> Yeah, this change really should have been an optional arg. It hurt the > >> readability and compactness of the output.

Re: [PATCH] scripts/faddr2line: show the code context

2018-05-29 Thread NeilBrown
On Tue, May 29 2018, Peter Zijlstra wrote: > On Tue, May 29, 2018 at 12:07:10PM -0500, Josh Poimboeuf wrote: >> Yeah, this change really should have been an optional arg. It hurt the >> readability and compactness of the output. The above looks good to me. >> >> Care to send a proper patch? If

Re: [PATCH] scripts/faddr2line: show the code context

2018-05-29 Thread Peter Zijlstra
On Tue, May 29, 2018 at 07:24:30PM +0200, Peter Zijlstra wrote: > From: Peter Zijlstra (Intel) Shees, you'd figure I could type my own email address by now.. From: Peter Zijlstra (Intel) > > Commit 6870c0165feaa5 ("scripts/faddr2line: show the code context") > radically altered the output for

Re: [PATCH] scripts/faddr2line: show the code context

2018-05-29 Thread Peter Zijlstra
On Tue, May 29, 2018 at 12:07:10PM -0500, Josh Poimboeuf wrote: > Yeah, this change really should have been an optional arg. It hurt the > readability and compactness of the output. The above looks good to me. > > Care to send a proper patch? If you send it to Linus he might apply it > directly

Re: [PATCH] scripts/faddr2line: show the code context

2018-05-29 Thread Josh Poimboeuf
On Tue, May 29, 2018 at 06:26:36PM +0200, Peter Zijlstra wrote: > On Tue, May 29, 2018 at 06:03:32PM +0200, Peter Zijlstra wrote: > > On Mon, Mar 19, 2018 at 03:23:25PM +0800, changbin...@intel.com wrote: > > > From: Changbin Du > > > > > > Inspired by gdb command 'list', show the code context of

Re: [PATCH] scripts/faddr2line: show the code context

2018-05-29 Thread Peter Zijlstra
On Tue, May 29, 2018 at 06:03:32PM +0200, Peter Zijlstra wrote: > On Mon, Mar 19, 2018 at 03:23:25PM +0800, changbin...@intel.com wrote: > > From: Changbin Du > > > > Inspired by gdb command 'list', show the code context of target lines. > > Here is a example: > > > > $ scripts/faddr2line vmlinu

Re: [PATCH] scripts/faddr2line: show the code context

2018-05-29 Thread Peter Zijlstra
On Mon, Mar 19, 2018 at 03:23:25PM +0800, changbin...@intel.com wrote: > From: Changbin Du > > Inspired by gdb command 'list', show the code context of target lines. > Here is a example: > > $ scripts/faddr2line vmlinux native_write_msr+0x6 > native_write_msr+0x6/0x20: > arch_static_branch at ar