Re: [PATCH] sched: fix incorrect wait time and wait count statistics

2015-10-27 Thread Joonwoo Park
On Tue, Oct 27, 2015 at 01:57:28PM +0100, Peter Zijlstra wrote: > > (Excessive quoting for Olav) > > On Mon, Oct 26, 2015 at 06:44:48PM -0700, Joonwoo Park wrote: > > On 10/25/2015 03:26 AM, Peter Zijlstra wrote: > > > > Also note that on both sites we also set TASK_ON_RQ_MIGRATING -- albeit > >

Re: [PATCH] sched: fix incorrect wait time and wait count statistics

2015-10-27 Thread Peter Zijlstra
(Excessive quoting for Olav) On Mon, Oct 26, 2015 at 06:44:48PM -0700, Joonwoo Park wrote: > On 10/25/2015 03:26 AM, Peter Zijlstra wrote: > > Also note that on both sites we also set TASK_ON_RQ_MIGRATING -- albeit > > late. Can't you simply set that earlier (and back to QUEUED later) and > > te

Re: [PATCH] sched: fix incorrect wait time and wait count statistics

2015-10-26 Thread Joonwoo Park
On 10/25/2015 03:26 AM, Peter Zijlstra wrote: > On Sat, Oct 24, 2015 at 10:23:14PM -0700, Joonwoo Park wrote: >> @@ -1069,7 +1069,7 @@ static struct rq *move_queued_task(struct rq *rq, >> struct task_struct *p, int new >> { >> lockdep_assert_held(&rq->lock); >> >> -dequeue_task(rq, p,

Re: [PATCH] sched: fix incorrect wait time and wait count statistics

2015-10-25 Thread Peter Zijlstra
On Sat, Oct 24, 2015 at 10:23:14PM -0700, Joonwoo Park wrote: > @@ -1069,7 +1069,7 @@ static struct rq *move_queued_task(struct rq *rq, > struct task_struct *p, int new > { > lockdep_assert_held(&rq->lock); > > - dequeue_task(rq, p, 0); > + dequeue_task(rq, p, DEQUEUE_MIGRATING);

Re: [PATCH] sched: fix incorrect wait time and wait count statistics

2015-10-25 Thread Peter Zijlstra
On Sat, Oct 24, 2015 at 10:23:14PM -0700, Joonwoo Park wrote: > At present scheduler resets task's wait start timestamp when the task > migrates to another rq. This misleads scheduler itself into reporting > less wait time than actual by omitting time spent for waiting prior to > migration and als