Re: [PATCH] sched: cpu accounting controller (V2)

2007-12-01 Thread Balbir Singh
Paul Menage wrote: > Hi Vatsa, > > Thanks, this looks pretty good. > > On Nov 30, 2007 4:42 AM, Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: >> - Removed load average information. I felt it needs more thought (esp >> to deal with SMP and virtualized platforms) and can be added

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Paul Menage
Hi Vatsa, Thanks, this looks pretty good. On Nov 30, 2007 4:42 AM, Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > > - Removed load average information. I felt it needs more thought (esp > to deal with SMP and virtualized platforms) and can be added for > 2.6.25 after

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Ingo Molnar
* Balbir Singh <[EMAIL PROTECTED]> wrote: > > thx. Have you done targeted testing of it as well? The (v2) patch is > > in sched-devel.git: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched-devel.git > > Ingo > > Tested the patches on top of 2.6.24-rc3. The

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Balbir Singh
Ingo Molnar wrote: > * Balbir Singh <[EMAIL PROTECTED]> wrote: > >> Srivatsa Vaddagiri wrote: >> [snip] >> >>> Signed-off-by: Srivatsa Vaddagiri <[EMAIL PROTECTED]> >>> >> Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> > > thx. Have you done targeted testing of it as well? The (v2) patch is in

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Balbir Singh
Ingo Molnar wrote: > * Balbir Singh <[EMAIL PROTECTED]> wrote: > >> Srivatsa Vaddagiri wrote: >> [snip] >> >>> Signed-off-by: Srivatsa Vaddagiri <[EMAIL PROTECTED]> >>> >> Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> > > thx. Have you done targeted testing of it as well? The (v2) patch is in

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Ingo Molnar
* Balbir Singh <[EMAIL PROTECTED]> wrote: > Srivatsa Vaddagiri wrote: > [snip] > > > Signed-off-by: Srivatsa Vaddagiri <[EMAIL PROTECTED]> > > > Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> thx. Have you done targeted testing of it as well? The (v2) patch is in sched-devel.git: git://g

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Ingo Molnar
* Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > On Fri, Nov 30, 2007 at 01:35:13PM +0100, Ingo Molnar wrote: > > * Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > > > > > Here's V2 of the cpu acccounting controller patch, which makes > > > accounting scale better on SMP systems by splitting t

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Srivatsa Vaddagiri
On Fri, Nov 30, 2007 at 01:35:13PM +0100, Ingo Molnar wrote: > * Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > > > Here's V2 of the cpu acccounting controller patch, which makes > > accounting scale better on SMP systems by splitting the usage counter > > to be per-cpu. > > thanks, applied. B

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Balbir Singh
Srivatsa Vaddagiri wrote: [snip] > Signed-off-by: Srivatsa Vaddagiri <[EMAIL PROTECTED]> > Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] sched: cpu accounting controller (V2)

2007-11-30 Thread Ingo Molnar
* Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > Here's V2 of the cpu acccounting controller patch, which makes > accounting scale better on SMP systems by splitting the usage counter > to be per-cpu. thanks, applied. But you dont seem to have incorporated all of the review feedback from And

Re: [PATCH] sched: cpu accounting controller

2007-11-29 Thread Srivatsa Vaddagiri
On Thu, Nov 29, 2007 at 11:30:35AM -0800, Andrew Morton wrote: > > - Make the accounting scalable on SMP systems (perhaps > > for 2.6.25) > > That sounds like a rather important todo. How bad is it now? It is indeed an important todo. Right now we take a per-group global lock on every

Re: [PATCH] sched: cpu accounting controller

2007-11-29 Thread Andrew Morton
On Fri, 30 Nov 2007 00:47:37 +0530 Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > On Mon, Nov 12, 2007 at 11:57:03PM -0800, Paul Menage wrote: > > > Regarding your concern about tracking cpu usage in different ways, it > > > could be mitigated if we have cpuacct controller track usage as per > >

Re: [PATCH] sched: cpu accounting controller

2007-11-29 Thread Srivatsa Vaddagiri
On Thu, Nov 29, 2007 at 08:20:58PM +0100, Ingo Molnar wrote: > ok, this looks certainly doable for v2.6.24. I've added it to the > scheduler fixes queue and will let it brew there for a few days and send > it to Linus after that if everything goes fine - unless anyone objects. Thanks. -- Rega

Re: [PATCH] sched: cpu accounting controller

2007-11-29 Thread Ingo Molnar
* Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > Paul, > Sorry about the delay in getting back to this thread. I realized > very recently that cpuacct controller has been removed from Linus's tree > and have attempted to rework it as per our discussions. > > Linus/Ingo, > Commit cfb