Re: [PATCH] sched: Introduce TASK_NOLOAD and TASK_IDLE

2015-05-13 Thread Julian Anastasov
Hello, On Tue, 12 May 2015, Peter Zijlstra wrote: > > msleep will not return until timeout has expired. > > Instead, we want to notice the kthread_should_stop() event > > immediately. Additionally, TASK_UNINTERRUPTIBLE will increase > > the load average. We can do it with extra wait

Re: [PATCH] sched: Introduce TASK_NOLOAD and TASK_IDLE

2015-05-12 Thread Peter Zijlstra
On Mon, May 11, 2015 at 10:34:11PM +0300, Julian Anastasov wrote: > On Mon, 11 May 2015, Peter Zijlstra wrote: > > > > - schedule_timeout_idle (instead of schedule_timeout call): > > > __set_current_state(TASK_IDLE); > > > return schedule_timeout(timeout); > > > > > > - we here are really i

Re: [PATCH] sched: Introduce TASK_NOLOAD and TASK_IDLE

2015-05-11 Thread Julian Anastasov
Hello, On Mon, 11 May 2015, Peter Zijlstra wrote: > > - schedule_timeout_idle (instead of schedule_timeout call): > > __set_current_state(TASK_IDLE); > > return schedule_timeout(timeout); > > > > - we here are really idle, so "N" looks ok > > So I don't get the point of the

Re: [PATCH] sched: Introduce TASK_NOLOAD and TASK_IDLE

2015-05-11 Thread Peter Zijlstra
On Sat, May 09, 2015 at 11:49:01AM +0300, Julian Anastasov wrote: > After checking our code in net/netfilter/ipvs/ip_vs_sync.c, > sync_thread_master(), we may also need some wrappers: > > - schedule_timeout_idle (instead of schedule_timeout call): > __set_current_state(TASK_IDLE); >

Re: [PATCH] sched: Introduce TASK_NOLOAD and TASK_IDLE

2015-05-11 Thread NeilBrown
On Sat, 9 May 2015 11:49:01 +0300 (EEST) Julian Anastasov wrote: > > Hello, > > On Fri, 8 May 2015, Peter Zijlstra wrote: > > > Subject: sched: Introduce TASK_NOLOAD and TASK_IDLE > > From: Peter Zijlstra > > Date: Fri May 8 14:23:45 CEST 2015 > > > > Currently people use TASK_INTERRUP

Re: [PATCH] sched: Introduce TASK_NOLOAD and TASK_IDLE

2015-05-09 Thread Julian Anastasov
Hello, On Fri, 8 May 2015, Peter Zijlstra wrote: > Subject: sched: Introduce TASK_NOLOAD and TASK_IDLE > From: Peter Zijlstra > Date: Fri May 8 14:23:45 CEST 2015 > > Currently people use TASK_INTERRUPTIBLE to idle kthreads and wait for > 'work' because TASK_UNINTERRUPTIBLE contributes