Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-13 Thread Xunlei Pang
On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: > On 04/10/2017 11:22 AM, Xunlei Pang wrote: >> I was testing Daniel's changes with his test case in the commit >> df8eac8cafce ("sched/deadline: Throttle a constrained deadline >> task activated after the deadline"), and tweaked it a lit

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-12 Thread Xunlei Pang
On 04/12/2017 at 09:10 PM, luca abeni wrote: > On Wed, 12 Apr 2017 20:30:04 +0800 > Xunlei Pang wrote: > [...] >>> If the relative deadline is different from the period, then the >>> check is an approximation (and this is the big issue here). I am >>> still not sure about what is the best thing to

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-12 Thread luca abeni
On Wed, 12 Apr 2017 20:30:04 +0800 Xunlei Pang wrote: [...] > > If the relative deadline is different from the period, then the > > check is an approximation (and this is the big issue here). I am > > still not sure about what is the best thing to do in this case. > > > >> E.g. For (runtime 2ms,

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-12 Thread Steven Rostedt
On Wed, 12 Apr 2017 20:30:04 +0800 Xunlei Pang wrote: > Image this deadline task was preempted after running 0.1ms by another one > with an > earlier absolute deadline for 1.9ms, after scheduled back it will have the > same status > (1.9ms remaining runtime, 2ms remaining deadline) under the cu

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-12 Thread Xunlei Pang
On 04/12/2017 at 02:55 PM, Luca Abeni wrote: > Hi, > > On Wed, 12 Apr 2017 13:27:32 +0800 > Xunlei Pang wrote: > [...] >> The more I read the code, the more I am confused why >> dl_entity_overflow() is needed, if the task is before its deadline, >> just let it run. > Sorry for jumping in this thre

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-11 Thread Luca Abeni
Hi, On Wed, 12 Apr 2017 13:27:32 +0800 Xunlei Pang wrote: [...] > The more I read the code, the more I am confused why > dl_entity_overflow() is needed, if the task is before its deadline, > just let it run. Sorry for jumping in this thread; I did not read all of the previous emails, but I think

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-11 Thread Xunlei Pang
On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: > On 04/10/2017 11:22 AM, Xunlei Pang wrote: >> I was testing Daniel's changes with his test case in the commit >> df8eac8cafce ("sched/deadline: Throttle a constrained deadline >> task activated after the deadline"), and tweaked it a lit

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-11 Thread Xunlei Pang
On 04/11/2017 at 05:24 PM, Daniel Bristot de Oliveira wrote: > On 04/11/2017 09:06 AM, Xunlei Pang wrote: >> On 04/11/2017 at 01:53 PM, Xunlei Pang wrote: >>> On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: On 04/10/2017 11:22 AM, Xunlei Pang wrote: > I was testing Daniel's ch

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-11 Thread Daniel Bristot de Oliveira
On 04/11/2017 09:06 AM, Xunlei Pang wrote: > On 04/11/2017 at 01:53 PM, Xunlei Pang wrote: >> On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: >>> On 04/10/2017 11:22 AM, Xunlei Pang wrote: I was testing Daniel's changes with his test case in the commit df8eac8cafce ("sched/de

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-11 Thread Daniel Bristot de Oliveira
On 04/11/2017 03:36 AM, Xunlei Pang wrote: > On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: >> On 04/10/2017 11:22 AM, Xunlei Pang wrote: >>> I was testing Daniel's changes with his test case in the commit >>> df8eac8cafce ("sched/deadline: Throttle a constrained deadline >>> task act

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-11 Thread Xunlei Pang
On 04/11/2017 at 01:53 PM, Xunlei Pang wrote: > On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: >> On 04/10/2017 11:22 AM, Xunlei Pang wrote: >>> I was testing Daniel's changes with his test case in the commit >>> df8eac8cafce ("sched/deadline: Throttle a constrained deadline >>> task

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-10 Thread Xunlei Pang
On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: > On 04/10/2017 11:22 AM, Xunlei Pang wrote: >> I was testing Daniel's changes with his test case in the commit >> df8eac8cafce ("sched/deadline: Throttle a constrained deadline >> task activated after the deadline"), and tweaked it a lit

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-10 Thread Xunlei Pang
On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: > On 04/10/2017 11:22 AM, Xunlei Pang wrote: >> I was testing Daniel's changes with his test case in the commit >> df8eac8cafce ("sched/deadline: Throttle a constrained deadline >> task activated after the deadline"), and tweaked it a lit

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-10 Thread Daniel Bristot de Oliveira
On 04/10/2017 11:22 AM, Xunlei Pang wrote: > I was testing Daniel's changes with his test case in the commit > df8eac8cafce ("sched/deadline: Throttle a constrained deadline > task activated after the deadline"), and tweaked it a little. > > Instead of having the runtime equal to the deadline, I t