Re: [PATCH] sata_via: PATA support, resubmit

2007-01-09 Thread Jeff Garzik
Alan wrote: Signed-off-by: Alan Cox <[EMAIL PROTECTED]> Looks good to me, modulo minor comments below... New revision below Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied, thanks for your patience :) Two procedural notes: * you should include the patch description in each resend, so

Re: [PATCH] sata_via: PATA support, resubmit

2007-01-08 Thread Alan
> > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> > > Looks good to me, modulo minor comments below... New revision below Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-rc3-mm1/drivers/ata/sata_via.c linux-2.6.20-r

Re: [PATCH] sata_via: PATA support, resubmit

2007-01-08 Thread Jeff Garzik
Alan wrote: Just separate PATA and SATA operations. That way everything works as expected, and you don't unintentionally add lovely oopses all over the place. Ok - based on your pointers to [ab]using port_start you want something like this for now, with the port_start evaporating when Tejun's

Re: [PATCH] sata_via: PATA support, resubmit

2007-01-08 Thread Alan
> Just separate PATA and SATA operations. That way everything works as > expected, and you don't unintentionally add lovely oopses all over the > place. Ok - based on your pointers to [ab]using port_start you want something like this for now, with the port_start evaporating when Tejun's probe c

Re: [PATCH] sata_via: PATA support, resubmit

2007-01-08 Thread Jeff Garzik
Alan wrote: The problem you need to fix or work around is ata_probe_ent, which doesn't properly fill in ata_port info for this situation. Tejun has posted patches that kill ata_probe_ent, which you were pointed to. And which are not yet in the main tree leaving many users unable to install L

Re: [PATCH] sata_via: PATA support, resubmit

2007-01-08 Thread Alan
> The problem you need to fix or work around is ata_probe_ent, which > doesn't properly fill in ata_port info for this situation. Tejun has > posted patches that kill ata_probe_ent, which you were pointed to. And which are not yet in the main tree leaving many users unable to install Linux. Th

Re: [PATCH] sata_via: PATA support, resubmit

2007-01-08 Thread Jeff Garzik
Alan wrote: This is a clean version of the PATA support for the sata_via hardware. I'm resubmitting it since nothing has happened since the last submission despite promises of libata core changes. Given users actually need to use this stuff today and the code is clean it should get merged irrespe