Re: [PATCH] rtc: max77686: Properly handle regmap_irq_get_virq() error code

2016-02-04 Thread Alexandre Belloni
On 04/02/2016 at 09:26:35 +0900, Krzysztof Kozlowski wrote : > The regmap_irq_get_virq() can return 0 or -EINVAL in error conditions > but driver checked only for value of 0. > > This could lead to a cast of -EINVAL to an unsigned int used as a > interrupt number for devm_request_threaded_irq(). A

Re: [PATCH] rtc: max77686: Properly handle regmap_irq_get_virq() error code

2016-02-03 Thread Javier Martinez Canillas
Hello Krzysztof, On 02/03/2016 09:26 PM, Krzysztof Kozlowski wrote: The regmap_irq_get_virq() can return 0 or -EINVAL in error conditions but driver checked only for value of 0. This could lead to a cast of -EINVAL to an unsigned int used as a interrupt number for devm_request_threaded_irq(). A