Re: [PATCH] rmmod notifier chain

2005-09-09 Thread Andrew Morton
"Jan Beulich" <[EMAIL PROTECTED]> wrote: > > First, I rarely saw any kind of positive review feedback from lkml > besides the notification that you added something to your -mm tree > (negative things of course always arrive), yet no feedback at all is far > from meaning that a given patch is eve

Re: [PATCH] rmmod notifier chain

2005-09-09 Thread Paul Jackson
Jan wrote: > Hence I wouldn't consider it reasonable to > break up the debugger patch entirely and submit all the pieces at once, > because that could easily mean that if one intermediate piece doesn't > get accepted all the dependent pieces have been separated out > pointlessly. This statement so

Re: [PATCH] rmmod notifier chain

2005-09-09 Thread Jesper Juhl
On 9/9/05, Jan Beulich <[EMAIL PROTECTED]> wrote: [snip] > > First, I rarely saw any kind of positive review feedback from lkml > besides the notification that you added something to your -mm tree > (negative things of course always arrive), yet no feedback at all is far [snip] I wouldn't say onl

Re: [PATCH] rmmod notifier chain

2005-09-09 Thread Jan Beulich
>> That's funny - on one hand I'm asked to not submit huge patches (not by >> you, but by others), but on the other hand not having the consuming code >> in the same patch as the providing one is now deemed to be a problem. > >Nope. > >Each patch should do a single logical thing. That doesn't mean

Re: [PATCH] rmmod notifier chain (attempt 2)

2005-09-09 Thread Jan Beulich
>>> Tom Rini <[EMAIL PROTECTED]> 08.09.05 17:33:14 >>> >On Thu, Sep 08, 2005 at 05:03:58PM +0200, Jan Beulich wrote: >It's possible to do this a bit differently, if I'm guessing right at >what NLKD does. The following is from the KGDB patches (trimmed of some >other, unrelated to the notify part c

Re: [PATCH] rmmod notifier chain

2005-09-08 Thread Andrew Morton
"Jan Beulich" <[EMAIL PROTECTED]> wrote: > > >>> Christoph Hellwig <[EMAIL PROTECTED]> 08.09.05 17:16:24 >>> > >On Thu, Sep 08, 2005 at 05:03:58PM +0200, Jan Beulich wrote: > >> (Note: Patch also attached because the inline version is certain to > get > >> line wrapped.) Suggest you get a new emai

Re: [PATCH] rmmod notifier chain

2005-09-08 Thread Jan Beulich
>It's possible to do this a bit differently, if I'm guessing right at >what NLKD does. The following is from the KGDB patches (trimmed of some >other, unrelated to the notify part code): Hmm, yes, this seems to be the better way to go. Thanks, Jan - To unsubscribe from this list: send the line "

Re: [PATCH] rmmod notifier chain

2005-09-08 Thread Tom Rini
On Thu, Sep 08, 2005 at 05:03:58PM +0200, Jan Beulich wrote: > (Note: Patch also attached because the inline version is certain to get > line wrapped.) > > Debugging and maintenance support code occasionally needs to know not > only of module insertions, but also modulke removals. This adds a > n

Re: [PATCH] rmmod notifier chain

2005-09-08 Thread Jan Beulich
>> Debugging and maintenance support code occasionally needs to know not >> only of module insertions, but also modulke removals. This adds a >> notifier >> chain for this purpose. >> >> >> diff -Npru 2.6.13/kernel/module.c >> 2.6.13-rmmod-notifier/kernel/module.c >> --- 2.6.13/kernel/module.c 2

Re: [PATCH] rmmod notifier chain

2005-09-08 Thread Christoph Hellwig
On Thu, Sep 08, 2005 at 05:03:58PM +0200, Jan Beulich wrote: > (Note: Patch also attached because the inline version is certain to get > line wrapped.) > > Debugging and maintenance support code occasionally needs to know not > only of module insertions, but also modulke removals. This adds a > no

Re: [PATCH] rmmod notifier chain

2005-09-08 Thread viro
On Thu, Sep 08, 2005 at 04:16:24PM +0100, Christoph Hellwig wrote: > On Thu, Sep 08, 2005 at 05:03:58PM +0200, Jan Beulich wrote: > > (Note: Patch also attached because the inline version is certain to get > > line wrapped.) > > > > Debugging and maintenance support code occasionally needs to know

Re: [PATCH] rmmod notifier chain

2005-09-08 Thread Jan Beulich
>>> Christoph Hellwig <[EMAIL PROTECTED]> 08.09.05 17:16:24 >>> >On Thu, Sep 08, 2005 at 05:03:58PM +0200, Jan Beulich wrote: >> (Note: Patch also attached because the inline version is certain to get >> line wrapped.) >> >> Debugging and maintenance support code occasionally needs to know not >>

Re: [PATCH] rmmod notifier chain

2005-09-08 Thread Patrick McHardy
Jan Beulich wrote: > Debugging and maintenance support code occasionally needs to know not > only of module insertions, but also modulke removals. This adds a > notifier > chain for this purpose. > > > diff -Npru 2.6.13/kernel/module.c > 2.6.13-rmmod-notifier/kernel/module.c > --- 2.6.13/kernel/mo