Re: [PATCH] remove duplicating priority setting in try_to_free_p

2008-01-28 Thread minchan kim
I agree with you. If you will have a test result, Let me know it. On Jan 28, 2008 6:01 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 28 Jan 2008 15:43:56 +0900 "minchan kim" <[EMAIL PROTECTED]> wrote: > > > > I think this is actually a bugfix. The code you're removing doesn't do > > > t

Re: [PATCH] remove duplicating priority setting in try_to_free_p

2008-01-28 Thread Andrew Morton
On Mon, 28 Jan 2008 15:43:56 +0900 "minchan kim" <[EMAIL PROTECTED]> wrote: > > I think this is actually a bugfix. The code you're removing doesn't do the > > > > if (priority < zone->prev_priority) > > > > thing. > > > > shrink_zones() in try_to_free_pages() already called > note_zone_s

Re: [PATCH] remove duplicating priority setting in try_to_free_p

2008-01-27 Thread minchan kim
On Jan 28, 2008 2:33 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Sat, 26 Jan 2008 02:29:23 -0500 "minchan kim" <[EMAIL PROTECTED]> wrote: > > > shrink_zones in try_to_free_pages already set zone through > > note_zone_scanning_priority. > > So, setting prev_priority in try_to_free_pages is n

Re: [PATCH] remove duplicating priority setting in try_to_free_p

2008-01-27 Thread Andrew Morton
On Sat, 26 Jan 2008 02:29:23 -0500 "minchan kim" <[EMAIL PROTECTED]> wrote: > shrink_zones in try_to_free_pages already set zone through > note_zone_scanning_priority. > So, setting prev_priority in try_to_free_pages is needless. > > This patch is made by 2.6.24-rc8. > > Signed-off-by: barrios <