Re: [PATCH] remoteproc: k3-r5: Fix error handling when power-up failed

2024-08-28 Thread Mathieu Poirier
On Thu, Aug 22, 2024 at 10:52:40AM +0530, Beleswar Prasad Padhi wrote: > > On 21-08-2024 23:40, Jan Kiszka wrote: > > On 21.08.24 07:30, Beleswar Prasad Padhi wrote: > > > On 19-08-2024 20:54, Jan Kiszka wrote: > > > > From: Jan Kiszka > > > > > > > > By simply bailing out, the driver was violat

Re: [PATCH] remoteproc: k3-r5: Fix error handling when power-up failed

2024-08-21 Thread Jan Kiszka
On 22.08.24 07:42, Beleswar Prasad Padhi wrote: > > On 22-08-2024 10:57, Jan Kiszka wrote: >> On 22.08.24 07:22, Beleswar Prasad Padhi wrote: >>> On 21-08-2024 23:40, Jan Kiszka wrote: On 21.08.24 07:30, Beleswar Prasad Padhi wrote: > On 19-08-2024 20:54, Jan Kiszka wrote: >> From: Ja

Re: [PATCH] remoteproc: k3-r5: Fix error handling when power-up failed

2024-08-21 Thread Beleswar Prasad Padhi
On 22-08-2024 10:57, Jan Kiszka wrote: On 22.08.24 07:22, Beleswar Prasad Padhi wrote: On 21-08-2024 23:40, Jan Kiszka wrote: On 21.08.24 07:30, Beleswar Prasad Padhi wrote: On 19-08-2024 20:54, Jan Kiszka wrote: From: Jan Kiszka By simply bailing out, the driver was violating its rule an

Re: [PATCH] remoteproc: k3-r5: Fix error handling when power-up failed

2024-08-21 Thread Jan Kiszka
On 22.08.24 07:22, Beleswar Prasad Padhi wrote: > > On 21-08-2024 23:40, Jan Kiszka wrote: >> On 21.08.24 07:30, Beleswar Prasad Padhi wrote: >>> On 19-08-2024 20:54, Jan Kiszka wrote: From: Jan Kiszka By simply bailing out, the driver was violating its rule and internal >>> >>> Us

Re: [PATCH] remoteproc: k3-r5: Fix error handling when power-up failed

2024-08-21 Thread Beleswar Prasad Padhi
On 21-08-2024 23:40, Jan Kiszka wrote: On 21.08.24 07:30, Beleswar Prasad Padhi wrote: On 19-08-2024 20:54, Jan Kiszka wrote: From: Jan Kiszka By simply bailing out, the driver was violating its rule and internal Using device lifecycle managed functions to register the rproc (devm_rproc_a

Re: [PATCH] remoteproc: k3-r5: Fix error handling when power-up failed

2024-08-21 Thread Jan Kiszka
On 21.08.24 07:30, Beleswar Prasad Padhi wrote: > > On 19-08-2024 20:54, Jan Kiszka wrote: >> From: Jan Kiszka >> >> By simply bailing out, the driver was violating its rule and internal > > > Using device lifecycle managed functions to register the rproc > (devm_rproc_add()), bailing out with

Re: [PATCH] remoteproc: k3-r5: Fix error handling when power-up failed

2024-08-20 Thread Beleswar Prasad Padhi
On 19-08-2024 20:54, Jan Kiszka wrote: From: Jan Kiszka By simply bailing out, the driver was violating its rule and internal Using device lifecycle managed functions to register the rproc (devm_rproc_add()), bailing out with an error code will work. assumptions that either both or no