Re: [PATCH] regulator: cpcap: Add basic regulator support

2017-02-02 Thread Tony Lindgren
* Rob Herring [170201 09:15]: > On Mon, Jan 30, 2017 at 04:12:41PM -0800, Tony Lindgren wrote: > > +Example: > > + > > +cpcap_regulator: regulator@600 { > > unit-address with no reg prop. Oops thanks for spotting that. Will resend v2 shortly. Regards, Tony

Re: [PATCH] regulator: cpcap: Add basic regulator support

2017-02-01 Thread Rob Herring
On Mon, Jan 30, 2017 at 04:12:41PM -0800, Tony Lindgren wrote: > Many Motorola phones like droid 4 are using a custom PMIC called CPCAP > or 6556002. This PMIC is used with several SoCs, I've noticed at least > omap3, omap4 and Tegra2 based Motorola phones and tablets using it. > > Cc: devicet...@

Re: [PATCH] regulator: cpcap: Add basic regulator support

2017-01-31 Thread Mark Brown
On Tue, Jan 31, 2017 at 02:09:53PM -0800, Tony Lindgren wrote: > * Mark Brown [170131 13:14]: > > On Mon, Jan 30, 2017 at 04:12:41PM -0800, Tony Lindgren wrote: > > > + error = regmap_update_bits(rdev->regmap, rdev->desc->enable_reg, > > > +rdev->desc->enable_mask, > >

Re: [PATCH] regulator: cpcap: Add basic regulator support

2017-01-31 Thread Tony Lindgren
* Mark Brown [170131 13:14]: > On Mon, Jan 30, 2017 at 04:12:41PM -0800, Tony Lindgren wrote: > > + error = regmap_update_bits(rdev->regmap, rdev->desc->enable_reg, > > + rdev->desc->enable_mask, > > + rdev->desc->enable_val); > > + if

Re: [PATCH] regulator: cpcap: Add basic regulator support

2017-01-31 Thread Mark Brown
On Mon, Jan 30, 2017 at 04:12:41PM -0800, Tony Lindgren wrote: > +static int cpcap_regulator_is_enabled(struct regulator_dev *rdev) > +{ > + unsigned int value = 0; > + > + regmap_read(rdev->regmap, rdev->desc->enable_reg, &value); > + > + return ((value & rdev->desc->enable_mask) == r