> +static const struct i_table vsys_tbl[] = {
> > + ILINE(0, DA906X_ADC_MAX, 2500, 5500)
> > +};
> > +
> > +static const struct i_table adcin_tbl[] = {
> > + ILINE(0, DA906X_ADC_MAX, 0, 2500)
> > +};
> > +
> > +static const struct i_table tjunc_tbl[] = {
> > + ILINE(0, DA906X_ADC_MAX, 333, -8
On Wed, Jul 11, 2012 at 04:13:00PM +0100, Krystian Garbaciak wrote:
> Would it make more sense to have some special enum value for that case, let
> say
> there would be REGULATOR_STATUS_UNDEFINED?
> Returning 0 is interpreted as REGULATOR_STATUS_OFF outside the function.
> But it may change, if
> > > This is deliberate. It's not reporting an error, it's reporting an
> > > indeterminate status which is a different thing.
>
> > Ok, then I would propose to use REGULATOR_STATUS_OFF instead of 0, to
> > present
> > your deliberate decision here.
>
> I don't think you're fully understanding
On Wed, Jul 11, 2012 at 03:18:00PM +0100, Krystian Garbaciak wrote:
> > This is deliberate. It's not reporting an error, it's reporting an
> > indeterminate status which is a different thing.
> Ok, then I would propose to use REGULATOR_STATUS_OFF instead of 0, to present
> your deliberate decisi
> From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com]
> Sent: 11 July 2012 14:29
>
> On Wed, Jul 11, 2012 at 01:10:01PM +0100, Krystian Garbaciak wrote:
> > Fix typo for case REGULATOR_STATUS_STANDBY -> REGULATOR_MODE_STANDBY.
> > For undefined mode, return REGULATOR_STATUS_ERROR (0 is n
On Wed, Jul 11, 2012 at 01:10:01PM +0100, Krystian Garbaciak wrote:
> Fix typo for case REGULATOR_STATUS_STANDBY -> REGULATOR_MODE_STANDBY.
> For undefined mode, return REGULATOR_STATUS_ERROR (0 is not valid status).
This is deliberate. It's not reporting an error, it's reporting an
indeterminate
6 matches
Mail list logo
