Re: [PATCH] qedi: Fix a possible sleep-in-atomic bug in qedi_process_tmf_resp

2017-12-18 Thread Martin K. Petersen
Jia-Ju, > To fix it, GFP_KERNEL is replaced with GFP_ATOMIC. > > This bug is found by my static analysis tool(DSAC) and checked by my > code review. Applied to 4.16/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qedi: Fix a possible sleep-in-atomic bug in qedi_process_tmf_resp

2017-12-13 Thread Rangankar, Manish
On 13/12/17 2:41 PM, "Jia-Ju Bai" wrote: >The driver may sleep under a spinlock. >The function call path is: >qedi_cpu_offline (acquire the spinlock) > qedi_fp_process_cqes >qedi_mtask_completion > qedi_process_tmf_resp >kzalloc(GFP_KERNEL) --> may sleep > >To fix it, GFP_KERN