Re: [PATCH] pwm: spear: fix check on pwmchip_add() return value

2014-05-07 Thread Viresh Kumar
On 7 May 2014 14:19, Thierry Reding wrote: > Since this was obviously broken since 3.8 and nobody noticed I wonder if > there's really an urgent need for this in stable. I don't think there is any urgent need of this, in case somebody wants we can add it later. :) -- To unsubscribe from this list

Re: [PATCH] pwm: spear: fix check on pwmchip_add() return value

2014-05-07 Thread Thierry Reding
On Wed, May 07, 2014 at 02:02:24PM +0530, Viresh Kumar wrote: > On 7 May 2014 13:54, Thierry Reding wrote: > > So the current code would run clk_unprepare() on success, but not on > > failure. Does that cause any harm? > > Yeah, that would make the device unusable as clk_enable will always fail.

Re: [PATCH] pwm: spear: fix check on pwmchip_add() return value

2014-05-07 Thread Viresh Kumar
On 7 May 2014 13:54, Thierry Reding wrote: > So the current code would run clk_unprepare() on success, but not on > failure. Does that cause any harm? Yeah, that would make the device unusable as clk_enable will always fail. > Is the device still usable after this? Yes, this will fix the bug.

Re: [PATCH] pwm: spear: fix check on pwmchip_add() return value

2014-05-07 Thread Thierry Reding
On Wed, May 07, 2014 at 11:37:25AM +0530, Viresh Kumar wrote: > On Tue, May 6, 2014 at 2:59 AM, Beniamino Galvani wrote: > > pwmchip_add() returns zero on success and a negative value on error, > > so the condition of the check must be inverted. > > > > Signed-off-by: Beniamino Galvani > > --- >

Re: [PATCH] pwm: spear: fix check on pwmchip_add() return value

2014-05-06 Thread Viresh Kumar
On Tue, May 6, 2014 at 2:59 AM, Beniamino Galvani wrote: > pwmchip_add() returns zero on success and a negative value on error, > so the condition of the check must be inverted. > > Signed-off-by: Beniamino Galvani > --- > drivers/pwm/pwm-spear.c |2 +- > 1 file changed, 1 insertion(+), 1 de