Re: [PATCH] psi: fix aggregation idle shut-off

2019-02-05 Thread Suren Baghdasaryan
Hi Andrew, On Mon, Jan 28, 2019 at 3:06 PM Andrew Morton wrote: > > On Wed, 16 Jan 2019 14:35:01 -0500 Johannes Weiner wrote: > > > psi has provisions to shut off the periodic aggregation worker when > > there is a period of no task activity - and thus no data that needs > > aggregating. However

Re: [PATCH] psi: fix aggregation idle shut-off

2019-01-28 Thread Suren Baghdasaryan
On Mon, Jan 28, 2019 at 3:06 PM Andrew Morton wrote: > > On Wed, 16 Jan 2019 14:35:01 -0500 Johannes Weiner wrote: > > > psi has provisions to shut off the periodic aggregation worker when > > there is a period of no task activity - and thus no data that needs > > aggregating. However, while deve

Re: [PATCH] psi: fix aggregation idle shut-off

2019-01-28 Thread Andrew Morton
On Wed, 16 Jan 2019 14:35:01 -0500 Johannes Weiner wrote: > psi has provisions to shut off the periodic aggregation worker when > there is a period of no task activity - and thus no data that needs > aggregating. However, while developing psi monitoring, Suren noticed > that the aggregation clock

Re: [PATCH] psi: fix aggregation idle shut-off

2019-01-28 Thread Tejun Heo
Hello, On Wed, Jan 16, 2019 at 02:35:01PM -0500, Johannes Weiner wrote: > +/** > + * wq_worker_last_func - retrieve worker's last work function > + * > + * Determine the last function a worker executed. This is called from > + * the scheduler to get a worker's last known identity. Maybe it can de

Re: [PATCH] psi: fix aggregation idle shut-off

2019-01-28 Thread Tejun Heo
Hello, Andrew. On Mon, Jan 28, 2019 at 02:03:36PM -0800, Andrew Morton wrote: > > +#include "../workqueue_internal.h" > > "Only to be included by workqueue and core kernel subsystems" > > I'm not sure that psi qualifies. Perhaps wq_worker_last_func() should > be declared in include/linux/workqu

Re: [PATCH] psi: fix aggregation idle shut-off

2019-01-28 Thread Johannes Weiner
On Mon, Jan 28, 2019 at 02:03:36PM -0800, Andrew Morton wrote: > On Wed, 16 Jan 2019 14:35:01 -0500 Johannes Weiner wrote: > > +/** > > + * wq_worker_last_func - retrieve worker's last work function > > + * > > + * Determine the last function a worker executed. This is called from > > + * the sche

Re: [PATCH] psi: fix aggregation idle shut-off

2019-01-28 Thread Suren Baghdasaryan
On Mon, Jan 28, 2019 at 2:03 PM Andrew Morton wrote: > > On Wed, 16 Jan 2019 14:35:01 -0500 Johannes Weiner wrote: > > > psi has provisions to shut off the periodic aggregation worker when > > there is a period of no task activity - and thus no data that needs > > aggregating. However, while deve

Re: [PATCH] psi: fix aggregation idle shut-off

2019-01-28 Thread Andrew Morton
On Wed, 16 Jan 2019 14:35:01 -0500 Johannes Weiner wrote: > psi has provisions to shut off the periodic aggregation worker when > there is a period of no task activity - and thus no data that needs > aggregating. However, while developing psi monitoring, Suren noticed > that the aggregation clock

Re: [PATCH] psi: fix aggregation idle shut-off

2019-01-16 Thread Suren Baghdasaryan
Hi Johannes, Thanks for fixing this. I'll test this approach and report back the results within a day or two. On Wed, Jan 16, 2019 at 11:35 AM Johannes Weiner wrote: > > psi has provisions to shut off the periodic aggregation worker when > there is a period of no task activity - and thus no data