Re: [PATCH] printk: Remove print_prefix() calls with NULL buffer.

2018-12-12 Thread Sergey Senozhatsky
On (12/12/18 14:16), Petr Mladek wrote: > On Wed 2018-12-12 11:20:29, Sergey Senozhatsky wrote: > > On (12/11/18 18:49), Tetsuo Handa wrote: > > > > > > We can save lines/size by removing print_prefix() with buf == NULL. > > > This patch makes no functional change. > > > > > > Signed-off-by: Tets

Re: [PATCH] printk: Remove print_prefix() calls with NULL buffer.

2018-12-12 Thread Petr Mladek
On Wed 2018-12-12 11:20:29, Sergey Senozhatsky wrote: > On (12/11/18 18:49), Tetsuo Handa wrote: > > > > We can save lines/size by removing print_prefix() with buf == NULL. > > This patch makes no functional change. > > > > Signed-off-by: Tetsuo Handa > > Looks good to me, > Reviewed-by: Sergey

Re: [PATCH] printk: Remove print_prefix() calls with NULL buffer.

2018-12-11 Thread Sergey Senozhatsky
On (12/11/18 18:49), Tetsuo Handa wrote: > > We can save lines/size by removing print_prefix() with buf == NULL. > This patch makes no functional change. > > Signed-off-by: Tetsuo Handa Looks good to me, Reviewed-by: Sergey Senozhatsky Shouldn't this also have "Suggested-by: Petr Mladek" ?

Re: [PATCH] printk: Remove print_prefix() calls with NULL buffer.

2018-12-11 Thread Petr Mladek
On Tue 2018-12-11 18:49:05, Tetsuo Handa wrote: > We can save lines/size by removing print_prefix() with buf == NULL. > This patch makes no functional change. > > Signed-off-by: Tetsuo Handa Nice clean up. It makes the code better readable. Acked-by: Petr Mladek Best Regards, Petr