Re: [PATCH] prctl: Don't compile some of prctl functions when CRUI

2019-04-17 Thread Cyrill Gorcunov
On Wed, Apr 17, 2019 at 04:44:54PM +0200, Michal Koutný wrote: > On Wed, Apr 17, 2019 at 03:38:41PM +0300, Cyrill Gorcunov > wrote: > > I've a bit vague memory what we've ended up with, but iirc there was > > a problem with brk() syscall or similar. Then I think we left everything > > as is. > Wa

Re: [PATCH] prctl: Don't compile some of prctl functions when CRUI

2019-04-17 Thread Cyrill Gorcunov
On Wed, Apr 17, 2019 at 04:44:54PM +0200, Michal Koutný wrote: > On Wed, Apr 17, 2019 at 03:38:41PM +0300, Cyrill Gorcunov > wrote: > > I've a bit vague memory what we've ended up with, but iirc there was > > a problem with brk() syscall or similar. Then I think we left everything > > as is. > >

Re: [PATCH] prctl: Don't compile some of prctl functions when CRUI

2019-04-17 Thread Michal Koutný
On Wed, Apr 17, 2019 at 03:38:41PM +0300, Cyrill Gorcunov wrote: > I've a bit vague memory what we've ended up with, but iirc there was > a problem with brk() syscall or similar. Then I think we left everything > as is. Was this related to the removal of non PR_SET_MM_MAP operations too? Do you h

Re: [PATCH] prctl: Don't compile some of prctl functions when CRUI

2019-04-17 Thread Cyrill Gorcunov
On Wed, Apr 17, 2019 at 02:23:50PM +0200, Michal Koutný wrote: > Hi. > > I see this discussion somewhat faded away since the previous year. > > There was rework [1] that reduced (ab)use of mmap_sem in prctl > functions. > > Actually, there still remains the down_write() in prctl_set_mm. > I cons

Re: [PATCH] prctl: Don't compile some of prctl functions when CRUI

2019-04-17 Thread Michal Koutný
Hi. I see this discussion somewhat faded away since the previous year. There was rework [1] that reduced (ab)use of mmap_sem in prctl functions. Actually, there still remains the down_write() in prctl_set_mm. I considered at least replacing it with the mm_struct.arg_lock + down_read() but then I

Re: [PATCH] prctl: Don't compile some of prctl functions when CRUI

2018-04-20 Thread kbuild test robot
Hi Sergey, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc1 next-20180420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH] prctl: Don't compile some of prctl functions when CRUI

2018-04-20 Thread Andrew Morton
On Sat, 21 Apr 2018 04:37:41 +0800 kbuild test robot wrote: > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.17-rc1 next-20180420] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve

Re: [PATCH] prctl: Don't compile some of prctl functions when CRUI

2018-04-20 Thread kbuild test robot
Hi Sergey, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc1 next-20180420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits